Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Popup): add pinned and popperModifiers prop #3654

Merged
merged 5 commits into from
Jun 11, 2019

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Jun 10, 2019

Fixes #3615.

pinned

Will stop flipping of opened Popup.

popup-pinned

popperModifiers

We can't map all PopperJS modifiers to component's props, so it will be better to just export them to allow customize them.

Restore rending children in ComponentExample

I just noticed that we're are missing helpful descriptions in docs:

image

Fixed 💥

@codecov-io
Copy link

codecov-io commented Jun 10, 2019

Codecov Report

Merging #3654 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3654   +/-   ##
=======================================
  Coverage   99.81%   99.81%           
=======================================
  Files         174      174           
  Lines        2749     2749           
=======================================
  Hits         2744     2744           
  Misses          5        5
Impacted Files Coverage Δ
src/modules/Popup/Popup.js 98.24% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8950d7c...2644606. Read the comment docs.

@layershifter layershifter merged commit bcc1d06 into master Jun 11, 2019
@delete-merged-branch delete-merged-branch bot deleted the feat/popup-pinned branch June 11, 2019 20:00
mbakiev pushed a commit to mbakiev/Semantic-UI-React that referenced this pull request Jun 17, 2019
* feat(Popup): add pinned and popperModifiers prop

* add on='click'

* fix typings

* fix prop

* remove missing example, disable `keepTogether` with offset, update merge order
@RRSR
Copy link

RRSR commented Feb 25, 2020

Even after adding pinned the popup move up if squeezed

<StyledPopup basic content={<SomeKindaList />} flowing hoverable onOpen={props.p1} onClose={props.p2} open={props.p3} position='bottom right' trigger={( <StyledLinkMenuItem isOpenPopup={props.p1}> .......... </StyledLinkMenuItem> )} offset='0, -10' pinned />

So if I decrease the window size the popup moves up. How to fix the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Popup: positioning glitch when using negative vertical offset
3 participants