BREAKING(package): require React 16.8 #3733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
changed the title
Codecov Report
@@ Coverage Diff @@
## master #3733 +/- ##
=======================================
Coverage 99.83% 99.83%
=======================================
Files 175 175
Lines 3124 3124
=======================================
Hits 3119 3119
Misses 5 5Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGES
This PR bumps requirement of React to 16.8. That's all ⭐️
Why?
React 16.8 was released in February, 6 months ago from now. It offered Hooks support which will allow us to simplify existing code and will improve its maintainability. Actually, the main reason is that
@stardust-ui/*packages require React 16.8 and to use reuse them we should increase minimal version.As there are no breaking changes in React versions, update should be straightforward 🚀