Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lib): remove customPropTypes.as #3751

Merged
merged 1 commit into from
Aug 19, 2019
Merged

Conversation

layershifter
Copy link
Member

We don't need anymore customPropTypes.as because it exists in prop-types as PropTypes.elementType 🎉

@codecov-io
Copy link

codecov-io commented Aug 19, 2019

Codecov Report

Merging #3751 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3751   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files         175      175           
  Lines        3125     3125           
=======================================
  Hits         3120     3120           
  Misses          5        5
Impacted Files Coverage Δ
src/elements/List/List.js 100% <ø> (ø) ⬆️
src/elements/Button/ButtonGroup.js 100% <ø> (ø) ⬆️
src/modules/Sticky/Sticky.js 99.09% <ø> (ø) ⬆️
src/elements/List/ListList.js 100% <ø> (ø) ⬆️
src/modules/Search/SearchCategory.js 100% <ø> (ø) ⬆️
src/views/Card/Card.js 100% <ø> (ø) ⬆️
src/views/Item/ItemHeader.js 100% <ø> (ø) ⬆️
src/modules/Sidebar/SidebarPushable.js 100% <ø> (ø) ⬆️
src/views/Comment/Comment.js 100% <ø> (ø) ⬆️
src/views/Feed/FeedContent.js 100% <ø> (ø) ⬆️
... and 138 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d428b0...8523362. Read the comment docs.

@layershifter layershifter merged commit 128e95d into master Aug 19, 2019
@delete-merged-branch delete-merged-branch bot deleted the chore/rm-proptypes-as branch August 19, 2019 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants