Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FeedSummary): add missing space around content #3836

Merged
merged 4 commits into from
Dec 8, 2019

Conversation

ridvankaradag
Copy link
Contributor

No description provided.

@welcome
Copy link

welcome bot commented Nov 13, 2019

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov-io
Copy link

codecov-io commented Nov 13, 2019

Codecov Report

Merging #3836 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3836   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files         177      177           
  Lines        3145     3145           
=======================================
  Hits         3140     3140           
  Misses          5        5
Impacted Files Coverage Δ
src/views/Feed/FeedSummary.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d100174...d0657c0. Read the comment docs.

@levithomason
Copy link
Member

Thanks for noticing and contributing! It seems this is because there are missing required spaces before and after the content. I've added this logic to the FeedSummary component so it is always correct.

@levithomason levithomason changed the title missing space fix(FeedSummary): add missing space around content Dec 8, 2019
@levithomason levithomason merged commit 55386d6 into Semantic-Org:master Dec 8, 2019
@welcome
Copy link

welcome bot commented Dec 8, 2019

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants