Statistic: enhance shorthand props and propTypes

[layershifter]

1. Update README.md

I forget mark <Step> as implemented.

2. Update usage of Message

<Message> was updated to v1 API, I've updated its usage in docs.

3. Update Statistic's docs

I've updated naming of docs to the most recent pattern.

4. Update prop handling

1. Allow only string for shorthands.
2. Shorthands on StatisticLabel and StatisticLabel.
3. StatisticGroup:
   • Update key handling for children (antipattern with index usage);
   • Extend prop validation of items with Proptypes.shape.

[codecov-io]

Current coverage is 94.86% (diff: 100%)

Merging #390 into master will decrease coverage by <.01%

@@             master       #390   diff @@
==========================================
  Files            85         85          
  Lines          1111       1110     -1   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits           1054       1053     -1   
  Misses           57         57          
  Partials          0          0          

Powered by Codecov. Last update e1bbafd...b43d353

[levithomason]

FYI I think these would work as numbers as well.

[layershifter]

Nope 😄 22 is number, while '22' is string.

Ideas?

[levithomason]

I think we should just change the propType validation to string/number. Since technically it could support node as it ends up here:

<div {...rest} className={classes}>{children || value}</div>

[layershifter]

It cannot be node, as it's used for key on StepGroup.

---

Proptypes.oneOf([Proptypes.number, Proptypes.string])

I think that it's not good solution. This raises the question of the behavior of other properties.

[levithomason]

Good call. OK, perhaps we only stick with string/number then.

[layershifter]

If we use string/number, we need allow it to all shorthand props.

[levithomason]

Hm, I suppose you are right about this. Feel free to update here or we can merge this and make that update next.

[levithomason]

I'll make a separate PR for this actually. The PR will resolve #391.

[levithomason]

Thanks much for this! A few comments and we can merge.

[levithomason]

Anything else on this guy or is it ready for merging?

Replied on shorthand string/number types.

[layershifter]

I'll update it now with oneOf, so we will can merge it.

[levithomason]

Great, I'll merge this tomorrow. It's getting late here! 🌔

[levithomason]

Released in v0.34.2