Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass props and other data separately into all component callbacks #4465

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

skondrashov
Copy link

@skondrashov skondrashov commented Feb 20, 2024

Resolves #4464

All callbacks to components which need to process some internal value of the component have had to pull the data out of the object intended to mirrors the props that were passed into the component back to the parent. This PR separates those concepts, so that the callbacks receive internal values of components as separate parameters from the props object.

These are clearly breaking changes but they make the API cleaner and make it possible to see what values (including their types) the callbacks.

To make them easier to review, the changes are broken up into commits by each component which needed to be updated. All tests pass locally after every commit.

Copy link

welcome bot commented Feb 20, 2024

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

Copy link

vercel bot commented Feb 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
semantic-ui-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 3, 2024 6:39am

@skondrashov skondrashov changed the title make TextArea value always be a string Pass props and other data separately into all component callbacks Mar 2, 2024
Copy link

codecov bot commented Mar 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.50%. Comparing base (c579cab) to head (56418a2).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4465      +/-   ##
==========================================
- Coverage   99.50%   99.50%   -0.01%     
==========================================
  Files         186      186              
  Lines        3465     3464       -1     
==========================================
- Hits         3448     3447       -1     
  Misses         17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@layershifter
Copy link
Member

ACK on this, I won't be able to check this in upcoming two weeks, but I will follow up later. Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StrictTextAreaProps has a type that includes number and undefined for the "value" field
2 participants