update react and react-dom peerdeps to include v 19 #4513
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have been using semantic-ui-react (v3 beta) with react 19 for a good while without any issues. Can we please include that version in the react peer deps range so I can avoid having to do --legacy-peer-deps? I do not update the package version in this PR, but if you can do that and release a new version, that would be amazing. many thanks 🙏🏼
|
💖 Thanks for opening this pull request! 💖 Here is a list of things that will help get it across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4513 +/- ##
=======================================
Coverage 99.53% 99.53%
=======================================
Files 186 186
Lines 3463 3463
=======================================
Hits 3447 3447
Misses 16 16 ☔ View full report in Codecov by Sentry. |
|
seems like the Vercel deployment fails because of a too low nodejs version, not sure what you want to do about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been using semantic-ui-react (v3 beta) with react 19 for a good while without any issues. Can we please include that version in the react peer deps range so I can avoid having to do --legacy-peer-deps?
I do not update the package version in this PR, but if you can do that and release a new version, that would be amazing.
many thanks 🙏🏼