Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress bar eats 10% CPU #2316

Closed
dandv opened this issue May 29, 2015 · 4 comments
Closed

Progress bar eats 10% CPU #2316

dandv opened this issue May 29, 2015 · 4 comments
Milestone

Comments

@dandv
Copy link
Contributor

dandv commented May 29, 2015

I wouldn't normally care, but it turned out that Semantic UI's progress bar caused my laptop fan to start spinning at http://semantic-ui.com/. After removing the progress bar, CPU utilization fell below the threshold.

Here's a screencast. It's a little slow to allow the CPU usage to stabilize.
progress bar eats 10 cpu

Measured with Process Hacker on Windows 7 64-bit. Chrome 43.0.2357.81 m.

@jlukic
Copy link
Member

jlukic commented May 29, 2015

From checking CPU profiling in chrome, seems like the blinking cursor and progress bar both have to be removed to get CPU usage down to 0. Kinda amazing how much CPU usage comes from a simple css transition.

I'll remove progress bar from homepage for sure. Blinking cursor I'll stop after animation.

@jlukic jlukic added this to the 2.0 RC2 milestone Jun 1, 2015
@jlukic
Copy link
Member

jlukic commented Jun 5, 2015

Ignore that commit, incorrectly tagged.

I've gone ahead and removed blinking cursor after animation finishes, and removed progress bar from homepage examples.

I still need to redo homepage for launch.

@jlukic jlukic closed this as completed Jun 5, 2015
ph101pp pushed a commit to ph101pp/Semantic-UI that referenced this issue Jun 10, 2015
@lauri-elevant
Copy link
Contributor

lauri-elevant commented Oct 11, 2018

The latest version is still eating absurd amounts of CPU cycles for rendering this strange animation that does not seem to have any meaningful semantics to my mind. If you set the percentage of the progress bar to anything above 0, it starts this sweeping animation that is supposed to say that it is .. what exactly? :) I can't figure it out.

Nothing should be lost by adding:

    .ui.active.progress .bar::after {
      -webkit-animation: none !important;
      animation: none !important;
    }

Before and after:
screenshot from 2018-10-11 18-33-10

Even if the animation does carry some useful meaning, I'd argue that the cost of it should also be factored in.

@lubber-de

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants