Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Button] Disabled Pointer-events should overwrite loading #2933

Closed
peterfyj opened this issue Sep 1, 2015 · 7 comments
Closed

[Button] Disabled Pointer-events should overwrite loading #2933

peterfyj opened this issue Sep 1, 2015 · 7 comments
Milestone

Comments

@peterfyj
Copy link

peterfyj commented Sep 1, 2015

Default behavior of .loading button has been discussed in #1744 as being disabled. But in 2.0.8, .loading button has pointer-events: auto, and this cannot be overwritten even with the presence of .disabled.

See this JSFiddle for a test case.

@jlukic
Copy link
Member

jlukic commented Sep 1, 2015

This came as a side effect for adding a variable specifically to control whether loading should have pointer-events: none (in most cases this will cause issues with hover retriggering with an idle mouse on an element which can be a big no-no)

https://github.com/Semantic-Org/Semantic-UI/blob/master/src/themes/default/elements/button.variables#L125 should probably be '' not auto.

@jlukic jlukic changed the title ".loading" button not disabled, even with ".disabled" [Button] Remove pointer-events rule on loading button in default theme Sep 1, 2015
@jlukic jlukic added this to the 2.1.x milestone Sep 1, 2015
@kmd1970
Copy link

kmd1970 commented Mar 1, 2016

same issue.
https://jsfiddle.net/kmd1970/55qog60h/

@jlukic jlukic changed the title [Button] Remove pointer-events rule on loading button in default theme [Button] Disabled Pointer-events should overwrite loading Mar 4, 2016
@jlukic jlukic modified the milestones: 2.1.9, 2.1.x Mar 4, 2016
@jlukic
Copy link
Member

jlukic commented Mar 7, 2016

Fixed in next

@jlukic jlukic closed this as completed Mar 7, 2016
@kmd1970
Copy link

kmd1970 commented Mar 7, 2016

When is next release?

@jlukic
Copy link
Member

jlukic commented Mar 7, 2016

t.b.d

@jlukic jlukic modified the milestones: 2.1.9, 2.2 May 1, 2016
@mciunne
Copy link

mciunne commented Aug 24, 2017

I am having this same problem today. is this fixed ? or is there a workaround ? thx.

EDIT : ok, I was using a Form.Button, which still has this issue, but if I simply use a Button, then it seems to be fixed.

@wassimdevox
Copy link

still not fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants