[Header] Sub Header inside Header Should Force Display: Block

[scoman81]

The icon header examples have invalid HTML markup, as div is not allowed inside an H2 tag, and won't validate.

[jlukic]

Don't worry validation is meaningless. 😄

In all seriousness you can just use a span if it bothers you

[scoman81]

I kind of agree about the validation (personally) but I'm sure some people will have project requirements they have to meet for clients.

Using a span requires some extra markup, because it doesn't do line breaks like a div does. It's easy to do, but I thought I'd mention it due to being another exception to the tag-agnostic approach of SUI. I'm guessing there's a CSS way to make a span work the same as a div in this case.

[jlukic]

I think it makes sense to force display: block on sub header to allow it to work correctly regardless of tag.