-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dropdown] - fullTextSearch: true does not properly filter values #3085
Comments
Not sure if you just typo'd in the title or not, but the setting value is "searchFullText" not "fullTextSearch" |
same issue here (SUI 2.1.4). I confirm that the correct setting should be "fullTextSearch": "searchFullText" is meant for another setting that is not taken in account, apparently is
in my example code the actual result is a select tag converted into a searchable dropdown, with sorted options that are searched (erroneously, apparently) both for values and text and only at the beginning of the string. |
You're right - I was looking at the search code, not the dropdown code. My mistake! The option naming isn't consistent, and the fuzzySearch() function is confusing as all get-out, but my first inclination is that considering how amazing the rest of this library is, the author must have their reasons. Hopefully he'll comment at some point. (I'd be super interested to know why .indexOf() isn't good enough after forcing case.) |
The naming difference between dropdown/search I might consider adding a setting alias and removing in Fuzzy search is an algorithm designed to return results even with common input mistakes. @furins I haven't written a |
so @jlukic, what can you suggest to solve my issue? |
This is the intended behavior with full text search.
If someone wants to implement |
@jlukic ok for the but still I have the issue with fullTextSearch (fuzzy). It does not seems to search the way you described, it search only at the beginning of the string. (in search components fuzzysearch algorithm works as expected). Now I'm at work so I cannot prepare a full test case/example. I'll try to do it tomorrow. |
hi @furins do you have updates on implementing fullTextSearch exact or fuzzy? I need this feature and I'd like to help |
…t-search [Dropdown] Add exact search - #3085
It has been over a year since this was first opened. Is this every going to be merged into master so we can actually use this? The fuzzy matching is fairly flawed and really all I want is similar to those commits where it does a lower case match. |
Ignore my earlier comment. It appears that it already has been merged (I searched for "exact" instead of 'exact' in the changelog). It appears to only work correctly if http://jsfiddle.net/daneren2005/efp8z6Ln/400/ |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions. |
Expected
I was expecting being filtered here are
ANC - Acta Numerica
DRJ - Dance Research Journal
Result
Please see screenshot:
I think the search dropdown doesn't filter the exact values you've typed anywhere from the string.
P.S. I'm filtering via text and not via values.
The text was updated successfully, but these errors were encountered: