Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Back Peer Dependencies #3511

Closed
edkongz opened this issue Dec 27, 2015 · 4 comments
Closed

Add Back Peer Dependencies #3511

edkongz opened this issue Dec 27, 2015 · 4 comments

Comments

@edkongz
Copy link

edkongz commented Dec 27, 2015

I was wondering what is the solution for 2.1.7 for installing peer dependencies? As it stands I'm using node v4.2 npm 2.14.7 and it's not installing the appropriate peer dependences.

I read the issue on npm but no one addressed the problem. What is the solution to install multiple peer dependencies on npm 2?

@jlukic
Copy link
Member

jlukic commented Dec 27, 2015

Somehow a commit to remove peer dependencies got finangled into 2.1.7. This would cause things to break in NPM 2.

Generally, removing peer depencies works A-OK for NPM 3 (the dep graph is flat). Peer dependencies are ignored anyways,so this works out great.

For SUI to support both NPM 2 and 3 we should probably still be leaving peerDependencies until NPM2 support is dropped (probably SUI 3.0)

@jlukic jlukic added this to the 2.1.8 milestone Dec 27, 2015
@edkongz
Copy link
Author

edkongz commented Dec 28, 2015

Thanks for fixing that i'll just use 2.1.6 in the meantime.

@edkongz edkongz closed this as completed Dec 28, 2015
@amad4biz
Copy link

ok thanks I will stick with it until 2.1.8

@tiborsaas
Copy link

+1 on this issue.
temporal fix is to copy node_modules folder to the project folder, where the Gulpfile.js is.

@jlukic jlukic changed the title peer dependencies Add Back Peer Dependencies Jan 8, 2016
@jlukic jlukic closed this as completed Jan 8, 2016
jlukic added a commit that referenced this issue Jan 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants