Modules using 'requestAnimationFrame' are broken within firefox extensions

[iamolivinius]

I guess all of semantic-ui's modules are invoked like this.. more or less

;(function ( $, window, document, undefined ) {
  ...
})( jQuery, window, document );

This works fine in the usual browser window environment but fails for example if you invoke the sidebar module from a Firefox extension's content script.

TypeError: 'requestAnimationFrame' called on an object that does not implement interface Window.

Other famous JS libraries fixed similar issues by replacing the window object with the "real" global object. see:

lodash/lodash#1340
zloirock/core-js#91

I was able to fix the error by adding the following code (extracted from core-js) to the sidebar module:

var global = typeof window != 'undefined' && window.Math == Math
  ? window : typeof self != 'undefined' && self.Math == Math ? self : Function('return this')();

;(function ( $, window, document, undefined ) {
  ...
})( jQuery, global, document );

TC39 is also making some efforts in this direction but the proposed getGlobal function is not reliable within Firefox extensions: https://github.com/tc39/proposal-global#rationale

[jlukic]

Thanks for the thorough bug post.

Pretty easy fix with no downsides. Will probably toss that sucker right in the SEAF

[jlukic]

Thoughts on

;(function ( $, window, document, undefined ) {
...
})( jQuery, (typeof window != 'undefined' && window.Math == Math) ? window : (typeof self != 'undefined' && self.Math == Math) ? self : Function('return this')(), document );

[jlukic]

This should do it

[jlukic]

Argh messed up find & replace. Will fix in another commit.

[danmoller]

I still get this error when I try to put angular as a content script....

(Which can be solved with the workarond proposed by the OP)