Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tab] Bottom margin is incorrect when Tab has more than 4 tabs #4167

Closed
migiside opened this issue Jun 25, 2016 · 1 comment
Closed

[Tab] Bottom margin is incorrect when Tab has more than 4 tabs #4167

migiside opened this issue Jun 25, 2016 · 1 comment
Milestone

Comments

@migiside
Copy link

when trying to make more than 4 tabs. from 3rd to (last -1) tab's bottom margin is incorrect.

4 tabs Demo
http://jsfiddle.net/1dph6don/1/

5 tabs Demo
http://jsfiddle.net/y9wvkzz4/1/

I think
https://github.com/Semantic-Org/Semantic-UI/blob/master/src/definitions/collections/menu.less#L638-L644

.ui.tabular.menu + .attached:not(.top).segment,
.ui.tabular.menu + .attached:not(.top).segment + .attached:not(.top).segment { ... }

is

.ui.tabular.menu ~ .attached:not(.top).segment { ... }

@jlukic
Copy link
Member

jlukic commented Jun 26, 2016

Very clear bug.. not sure how that slipped. Fixed in 2.2.

@jlukic jlukic closed this as completed Jun 26, 2016
ali1k added a commit to slidewiki/custom-semantic-ui that referenced this issue Jul 1, 2016
…into Semantic-Org-master

* 'master' of https://github.com/Semantic-Org/Semantic-UI: (316 commits)
  Semantic-Org#4181 fix issue with jQ 3.0 width calculations causing shape to break
  Fix Semantic-Org#4181
  Semantic-Org#4192
  Build 2.2.1
  Fix selection issue with <select> and userAdditions
  Rlsnotes
  Build 2.2 for release
  Build 2.2 for release
  Build final dist
  Rlsnotes Semantic-Org#4144
  Rlsnotes noodling
  Semantic-Org#4167 - Tabular menu now has correct bottom margin in all cases
  Fix
  Fix rlsnotes
  Fix issue with hideAdditions where enter key would not select value when typing rapidly
  Update rlsnotes
  More accurate arrow positioning in tooltips
  Remove duplicate height definition
  Reset some styles in tooltip
  Fix issue where selection was borked for search inside menu
  ...
ali1k added a commit to slidewiki/custom-semantic-ui that referenced this issue Jul 1, 2016
* Semantic-Org-master: (316 commits)
  Semantic-Org#4181 fix issue with jQ 3.0 width calculations causing shape to break
  Fix Semantic-Org#4181
  Semantic-Org#4192
  Build 2.2.1
  Fix selection issue with <select> and userAdditions
  Rlsnotes
  Build 2.2 for release
  Build 2.2 for release
  Build final dist
  Rlsnotes Semantic-Org#4144
  Rlsnotes noodling
  Semantic-Org#4167 - Tabular menu now has correct bottom margin in all cases
  Fix
  Fix rlsnotes
  Fix issue with hideAdditions where enter key would not select value when typing rapidly
  Update rlsnotes
  More accurate arrow positioning in tooltips
  Remove duplicate height definition
  Reset some styles in tooltip
  Fix issue where selection was borked for search inside menu
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants