Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sticky] Dont Require Width/Height to be Set #4360

Closed
Jabark opened this issue Jul 29, 2016 · 2 comments
Closed

[Sticky] Dont Require Width/Height to be Set #4360

Jabark opened this issue Jul 29, 2016 · 2 comments
Milestone

Comments

@Jabark
Copy link

Jabark commented Jul 29, 2016

I've found an issue with the sticky module in that when it initialises it adds height and width to the element, and then when more components are loaded a scrollbar appears which causes the parent container to shrink, however the sticky element does not because it already has the width set to it. I have this issue currently within a Meteor application, however as a quick example of what happens, here's a fiddle to simulate it:

https://jsfiddle.net/3szcuj5z/5/

@jlukic
Copy link
Member

jlukic commented Jul 31, 2016

I think it makes sense to set width/height setting as a setting. Some cases are actually helped by forcing the element to a width, as fixed position will cause width: 100% to apply differently.

@jlukic jlukic changed the title [sticky] Issue with sticky module when website loaded with self contained components [sticky] Dont Require Width/Height to be Set Jul 31, 2016
@jlukic jlukic added this to the 2.2.4 milestone Jul 31, 2016
@jlukic jlukic modified the milestones: 2.2.6, 2.2.7, 2.2.8 Oct 28, 2016
@jlukic jlukic changed the title [sticky] Dont Require Width/Height to be Set [Sticky] Dont Require Width/Height to be Set Feb 20, 2017
@jlukic jlukic modified the milestones: 2.2.10, 2.2.11 Mar 28, 2017
@jlukic
Copy link
Member

jlukic commented Jul 2, 2017

Added a new setting in next version setSize which determines whether the sticky module should set the size automatically.

Also fixed another issue related to your test case wherer using a ui sticky in a relative width container would not resize when the browser size changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants