Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Visibility] lazy loading images not working on iOS #5194

Open
larsbo opened this issue Mar 23, 2017 · 8 comments
Open

[Visibility] lazy loading images not working on iOS #5194

larsbo opened this issue Mar 23, 2017 · 8 comments

Comments

@larsbo
Copy link
Contributor

larsbo commented Mar 23, 2017

I'm not sure what causes this problem but I guess it may be the sidebar module. I have a page using both sidebar and lazy loading images by the help of the visibility module. On desktop everything works fine but on iOS (iPhone 6) the images stay hidden during scrolling. They become visible when switching viewport to landscape and back so there must be some issue with the scrolling event.

It wasn't possible to create a jsfiddle that mimic this behavior but the best example is on the semantic ui page: https://semantic-ui.com/behaviors/visibility.html#lazy-loading-images
This page didn't load any image on latest iOS.

@awgv awgv added this to the Needs Milestone milestone Mar 24, 2017
@awgv
Copy link
Member

awgv commented Mar 24, 2017

This issue might be related: #4361.

@larsbo
Copy link
Contributor Author

larsbo commented Mar 24, 2017

#4361 says it's working on iOS, but not on macOS.

Meanwhile I found the reason for the bug I think. I have noticed that the iOS build-in scroll to top feature does not work either (touching on the very top of the iOS Safari bar where the current time is displayed). After googling a bit I found issue #1985 with @jlukic fix for the issue at that time:

html, body {
  height: initial;
}

It seems as the mentioned css does not exist anymmore in the code base. I added the css back and both issues (non working ios scrolling to top and non working lazy loading images) are gone.

Someone know why the css has been removed?

@awgv
Copy link
Member

awgv commented Mar 24, 2017

@larsbo here: ee05b71

Sidebar - Fixed bug where sidebar in iOS would show background behind page when page is less than 100% height #4264

And the reasoning.

@larsbo
Copy link
Contributor Author

larsbo commented Mar 25, 2017

@Banandrew thank you. It looks like we now have a bad mobile situation: either ugly dark background or non working visibility module 😦

I tested a little bit and found out that for making the visibility module working

html {
  height: initial;
}

is sufficient.

@stale
Copy link

stale bot commented Feb 23, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 23, 2018
@Prathapreddy26
Copy link

My issue is., when i am search and select a record in tableview., the data is displaying and image is not loading. But, Without searching a record and select a random record. The data is showing properly and image is also loading... What is the actual issue in this?

@stale stale bot removed the stale label Feb 26, 2018
@stale
Copy link

stale bot commented May 27, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 27, 2018
@larsbo
Copy link
Contributor Author

larsbo commented May 27, 2018

Stop staling

@stale stale bot removed the stale label May 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants