-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Sidebar] Sidebar in iOS #4264
Comments
Please also see latest note on #3701 |
I am also having this issue. So far i have tried to add the CSS above, but from the documentation i feel that this is already included in the Semantic Ui CSS file. I have also experimented with height values for the sidebar, body and pusher div without any luck. Have you had any luck finding a solution Lars? |
Same problem, but I have solved it. Basically, Semantic UI says that you need to add something like: But instead of code above, you should add this one: The problem with that first code is that it sets And the main problem is that Semantic UI includes "bad styles" by default, so you need to override them. All in all, this solution works. |
Sidebar detects ios in its initialization code and automatically adds class I think I have a fix, but will have to verify it's all safe when i'm able to debug on my phone later this week. |
Bugger. Was hoping for this one in 2.2.3. Anything I can do to test your fix @jlukic ? |
@jlukic Any updates on this? What's the proposed fix? |
I dont believe the height rules are necessary in the iOS fix anymore. The overflow rules however I can confirm are still very necessary, removing them will cause the bottom/top of sidebar to get cutoff due to the way iOS auto resizes document height when sidebar is visible. Fixed in |
Continuing on issue #2087 (currently closed)
Using the example from @Eliasvdb the output from the fiddle is this url:
http://fiddle.jshell.net/dzm8b28s/show/
The problem is that if you try to display that specific page in either iOS simulator or in safari on iOS then the height of the sidebar is only the height of the content - and the rest is hidden. Please see this image as an illustration.
I have tried to add this css (from the sidebar docs).
it is not clear from the docs (to me) if I manually should add the userAgent detection any ideas how this could be resolved?
The text was updated successfully, but these errors were encountered: