[build] gulp build command not working #5391

simoncarbajal · 2017-05-21T15:34:32Z

gulp build can't complete the 'build-assets' phase due to the following error:

GulpUglifyError: unable to minify JavaScript
Caused by: DefaultsError: `preserveComments` is not a supported option
semantic/tasks/config/tasks.js:96
          if(error.filename.match(/theme.less/)) {
                           ^
TypeError: Cannot read property 'match' of undefined

And is NOT fixed by commenting the following lines:

./tasks/config/tasks.js:148:      preserveComments : 'some'
./tasks/config/tasks.js:162:      preserveComments : false

Steps to reproduce it:

npm install semantic-ui --save
cd semantic/
gulp build

The text was updated successfully, but these errors were encountered:

fabulousduck · 2017-06-01T14:22:59Z

would also like to see this answered as i am having the same issue. ⌛️

fabulousduck · 2017-06-01T14:34:02Z

i tried to resolve this by downloading the semantic zip from the website.
although this zip does not contain everything and will still error out giving the following
This relative module was not found: *./themes/default/assets/images/loader-large.gif in ./~/css-loader?{"minimize":false,"sourceMap":false}!./semantic/dist/semantic.min.css

fabulousduck · 2017-06-01T14:49:41Z

@simoncarbajal i fixed this by completely removing semantic and reinstalling it. not sure where the cause lies. 🤷‍♂️

tarkwyn · 2017-06-22T09:50:49Z

Fix is to change filename to fileName in line 96 of semantic/tasks/config/tasks.js

e.g. if(error.fileName.match(/theme.less/)) {

j-f1 · 2017-06-22T11:38:10Z

@tarkwyn Can you make a pull request to fix this?

SamPlusPlus · 2017-07-06T15:52:07Z

I can confirm that @tarkwynl 's change worked for me. I can provide additional details if needed.

designosis · 2017-07-07T18:07:01Z

The camelCase issue didn't cause any problems, however I was unable to successfully gulp build until I commented out the two preserveComments tags in /semantic/tasks/config/tasks.js

The error (with "gulp-uglify": "^3.0.0"):

[13:56:35] Created: dist/components/site.js
[13:56:35] Plumber found unhandled error:
 GulpUglifyError: unable to minify JavaScript
Caused by: DefaultsError: `preserveComments` is not a supported option
File: /Volumes/DATA/WWW/skilled/semantic/dist/components/site.js

SamPlusPlus · 2017-07-07T18:10:09Z

@neokio I also received the perserveComments error, but I had to upgrade my version of node to the latest, to get pass that.

I will not very experienced with gulp/node so take my inputs with a grain of salt.

designosis · 2017-07-07T18:29:52Z

Interesting! Good advice in general, so I updated node from 7.7.1 to the latest (8.1.3), and reinstalled npm (npm install -g npm) just to be sure.

The above error still appears, unless I remove both perserveComments.

designosis · 2017-07-11T17:02:27Z

The error persists in 2.2.11 ... unable to successfully gulp build until I removed both preserveComments lines from /semantic/tasks/config/tasks.js.

SamPlusPlus · 2017-07-11T17:49:41Z

@neokio could be unrelated, but when I said I updated to the latest for Node Js I actually went for LTS, not current. https://nodejs.org/en/ so I went on version 6.11.1

designosis · 2017-07-11T18:46:47Z

I think I found the problem. This issue ... terinjokes/gulp-uglify#265 ... and the latest gulp-uglify release notes reveal that release v3.0.0 of gulp-uglify REMOVED the custom option preserveComments :)

vinayakkulkarni · 2017-07-12T07:56:58Z

Yep, can confirm the issue. Commenting out L148 & L162 (temporarily) solves it.

Tried with older version of Node / npm & latest version too.
It's not camelCase related or node version related

rafaelgilead · 2017-07-14T23:14:17Z

After all, what will be done in the semantic ui ? To remove the option or comment and wait for uglify downgrade ?

jlukic · 2017-07-15T00:42:15Z

I'll fix the dependencies so that we dont use this version of uglify. Sorry about this guys.

jpetitte · 2017-07-22T16:55:15Z

I'm a little late to the party, but I figure another confirmation can't hurt. Commenting out L148 & L162 worked for me as well. Thanks!

rafaelgilead · 2017-07-22T17:05:44Z

Commenting out L148 & L162. It worked for me too.

bhargavy · 2017-07-24T06:18:08Z

Commenting out L148 & L162. It worked for me too.

Madankapoor · 2017-07-28T04:48:31Z

Commenting out only worked , can't find out if issue is in gulp-uglify or semantic ui.

jlukic · 2017-07-28T14:09:14Z

Will get fix in over weekend. Thanks for patience.

cur33 · 2017-07-31T17:27:23Z

Commenting worked for me, too. Glad I wasn't the only one with this problem, since I'm new to semantic ui and gulp--and I'm on a time crunch! Thanks guys!

sergiomar73 · 2017-08-02T14:07:52Z

Hi, I found that Uglify plugin changed its options and now preserveComments is obsolete:

https://github.com/gruntjs/grunt-contrib-uglify#deprecated-options-from-2x

Option           | Replacement
preserveComments | output.comments

So, just replacing in these 2 lines in semantic/tasks/config/tasks.js:

./tasks/config/tasks.js:148:      preserveComments : 'some'
./tasks/config/tasks.js:162:      preserveComments : false

with:

output: {
    comments: 'some'
}

output: {
    comments: false
}

worked for me.

kevinmwangi · 2017-08-02T15:31:47Z

@sergiomar73 Thanks this fixed it

basselAhmed · 2017-08-02T19:07:14Z

@sergiomar73 Thanks man, I can confirm this fixes it.

cluxter · 2017-08-02T21:32:41Z

@sergiomar73 I confirm it too.

kutalev · 2017-08-03T00:56:54Z

@sergiomar73 It worked. Thanks!

jlukic · 2017-08-06T16:30:31Z

A weekend late but pushing this now.

erdi · 2017-08-06T16:54:40Z

What's the timeline for releasing 2.2.12, @jlukic?

cluxter · 2017-08-06T17:52:05Z

It's kind of too bad that we have to wait until v2.2.12 is released to see this bug fixed :/
This is a blocking issue for the one who doesn't patch manually and needs to use gulp (sometimes you have to). Wouldn't a v2.2.11.1 be a better solution? Just asking.

jlukic · 2017-08-06T19:59:09Z

@cluxter dont worry, I'm releasing this later tonight. Continuing to jam on issues. Manual fix above should work in interim.

axper · 2017-08-07T11:24:18Z

Hmm, still getting this error with v2.2.12:

[15:23:13] Plumber found unhandled error:
 GulpUglifyError: unable to minify JavaScript
Caused by: DefaultsError: `comments` is not a supported option
File: /home/axper/project/semantic/dist/components/sticky.js

zehmigueljr · 2017-08-07T12:41:25Z

Hi @jlukic , I tried build a test of semantic and the same problem occured. The file tasks.js
already in the new version, with your last commit. I had to apply the solution that @sergiomar73 showed.
I tried build in 2.2.11 and 2.2.12.

jlukic · 2017-08-07T15:55:13Z

Patch incoming

jlukic · 2017-08-07T16:25:11Z

And out 2.2.13

zehmigueljr · 2017-08-07T17:36:33Z

Hi, @jlukic
I have installed de last updates (2.2.13) of semantic and tried build the project.
The fix worked succefully.

Thanks a lot.

jlukic · 2017-08-07T18:40:44Z

Sorry about mistakes with the first fix.

cluxter · 2017-08-08T01:11:08Z

v2.2.13 works on my side. Thanks a lot @jlukic !

…sue with 2.2.11 (Semantic-Org/Semantic-UI#5391)

flornet · 2017-11-15T14:16:14Z

Hi, I've been having the exact same issue with 2.2.13.
To solve it, I've had to update Node.js & NPM.
It might be obvious... but it wasn't for me :)

dickmao · 2017-11-22T12:27:04Z

Yes, can confirm that default version of nodejs 4.2.6 for ubuntu 16.04 won't work. Needed to upgrade to 6.x.x. Thanks.

peppelinux · 2018-04-09T08:36:14Z

Confirmed that it's a problem related to nodejs version. Fixed with:

export NODE_VERSION="node-v8.11.1-linux-x64"
cd /opt
# LTS version
wget https://nodejs.org/dist/v8.11.1/$NODE_VERSION.tar.xz
# decompress it
tar xvf $NODE_VERSION.tar.xz

# put it in the executables defaults environment path
export PATH=$PATH:/opt/$NODE_VERSION/bin:$PWD/node_modules/bower/bin

then use node.js as usual.
Remember also to uninstall previous node.js installations

harshsingh206 · 2018-05-14T13:52:48Z

Plumber found unhandled error:
GulpUglifyError: unable to minify JavaScript
Caused by: SyntaxError: Unexpected token: punc ())

Any idea on this?

awgv added Build Tools Evaluating Bug / Change labels May 22, 2017

awgv added this to the Needs Milestone milestone May 22, 2017

tarkwyn mentioned this issue Jul 4, 2017

5391 camelcase error filename #5503

Closed

jlukic modified the milestones: 2.2.12, Needs Milestone Jul 11, 2017

jlukic added the High Priority label Jul 11, 2017

jlukic added a commit that referenced this issue Aug 6, 2017

#5391 - Fixes issue with deprecated uglify setting in build tools

cd3a639

jlukic closed this as completed Aug 6, 2017

sergiomar73 mentioned this issue Aug 7, 2017

Fixed Gulp Build Comments Error #5637

Closed

jlukic added a commit that referenced this issue Aug 7, 2017

Really fix #5391

52922d1

erdi added a commit to apache/groovy-geb that referenced this issue Oct 5, 2017

Fix site's dependency on semantic-ui to 2.2.10 because there is an is…

08621fe

…sue with 2.2.11 (Semantic-Org/Semantic-UI#5391)

brownspy1 mentioned this issue Jun 29, 2024

[Snyk] Upgrade semantic-ui from 2.2.6 to 2.5.0 brownspy1/AhMyth-Android-RAT#2

Merged

DarkCipherNinja mentioned this issue Oct 18, 2024

[Snyk] Upgrade semantic-ui from 2.2.6 to 2.5.0 DarkCipherNinja/AhMyth-Android-RAT#157

Open

[build] gulp build command not working #5391

[build] gulp build command not working #5391

Comments

simoncarbajal commented May 21, 2017 • edited Loading

fabulousduck commented Jun 1, 2017

fabulousduck commented Jun 1, 2017

fabulousduck commented Jun 1, 2017

tarkwyn commented Jun 22, 2017

j-f1 commented Jun 22, 2017

SamPlusPlus commented Jul 6, 2017 • edited Loading

designosis commented Jul 7, 2017 • edited Loading

SamPlusPlus commented Jul 7, 2017

designosis commented Jul 7, 2017

designosis commented Jul 11, 2017 • edited Loading

SamPlusPlus commented Jul 11, 2017

designosis commented Jul 11, 2017 • edited Loading

vinayakkulkarni commented Jul 12, 2017 • edited Loading

rafaelgilead commented Jul 14, 2017

jlukic commented Jul 15, 2017

jpetitte commented Jul 22, 2017

rafaelgilead commented Jul 22, 2017

bhargavy commented Jul 24, 2017

Madankapoor commented Jul 28, 2017

jlukic commented Jul 28, 2017

cur33 commented Jul 31, 2017

sergiomar73 commented Aug 2, 2017

kevinmwangi commented Aug 2, 2017

basselAhmed commented Aug 2, 2017

cluxter commented Aug 2, 2017

kutalev commented Aug 3, 2017

jlukic commented Aug 6, 2017

erdi commented Aug 6, 2017

cluxter commented Aug 6, 2017

jlukic commented Aug 6, 2017 • edited Loading

axper commented Aug 7, 2017

zehmigueljr commented Aug 7, 2017

jlukic commented Aug 7, 2017

jlukic commented Aug 7, 2017

zehmigueljr commented Aug 7, 2017

jlukic commented Aug 7, 2017

cluxter commented Aug 8, 2017

flornet commented Nov 15, 2017

dickmao commented Nov 22, 2017

peppelinux commented Apr 9, 2018 • edited Loading

harshsingh206 commented May 14, 2018

simoncarbajal commented May 21, 2017 •

edited

Loading

SamPlusPlus commented Jul 6, 2017 •

edited

Loading

designosis commented Jul 7, 2017 •

edited

Loading

designosis commented Jul 11, 2017 •

edited

Loading

designosis commented Jul 11, 2017 •

edited

Loading

vinayakkulkarni commented Jul 12, 2017 •

edited

Loading

jlukic commented Aug 6, 2017 •

edited

Loading

peppelinux commented Apr 9, 2018 •

edited

Loading