Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Image] Image Group css should only apply to direct children #6224

Closed
jacknevitt opened this issue Feb 27, 2018 · 1 comment
Closed

[Image] Image Group css should only apply to direct children #6224

jacknevitt opened this issue Feb 27, 2018 · 1 comment
Labels
Confirmed Bug
Milestone
2.3.1

Comments

@jacknevitt
Copy link

jacknevitt commented Feb 27, 2018 •
edited
Loading

Steps

<div class="ui small images">
  <a href="http://google.com" class="ui medium image">
    <img src="https://source.unsplash.com/bmALnwwLumQ/150x100"/>
  </a>
  <a href="http://google.com" class="ui medium image">
    <img src="https://source.unsplash.com/bmALnwwLumQ/150x100"/>
  </a>
</div>

Expected Result

Correct margins are only applied to <a> and not <img>

Actual Result

Margin is applied to both <a> and <img>

Version

2.3.0

Testcase

https://codepen.io/Jacknev/pen/QQJZMY
@jlukic jlukic added this to the 2.3.1 milestone Feb 28, 2018
jlukic added a commit that referenced this issue Mar 19, 2018
@jlukic
Fix double margin on nested images #6224
b93737e
@jlukic
Copy link
Member

jlukic commented Mar 19, 2018

Fixed in 2.3.1

@jlukic jlukic closed this as completed Mar 19, 2018
@brownspy1 brownspy1 mentioned this issue Jun 29, 2024
Merged
@BLACK-NINJA-PK BLACK-NINJA-PK mentioned this issue Oct 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Confirmed Bug
Projects
None yet
Milestone
2.3.1
Development

No branches or pull requests
2 participants
@jlukic @jacknevitt