Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dropdown] Fix IE11 dropdown re-focus issue #5965

Closed
wants to merge 1 commit into from

Conversation

andrei-piatrou
Copy link

@andrei-piatrou andrei-piatrou commented Nov 20, 2017

@jokeronaldo Here is JSFiddle.

  1. Please, use IE11 to reproduce the bug.
  2. Click on user icon and choose Settings for example.

Actual result: dropdown will be closed and immediately opened.
Expected result: dropdown is closing and will not be opened as it is in other browsers.

@andrei-piatrou andrei-piatrou changed the title Fix IE11 dropdown re-focus issue [Dropdown] Fix IE11 dropdown re-focus issue Jan 4, 2018
@jlukic
Copy link
Member

jlukic commented Jan 29, 2018

I was able to reproduce.

This is caused by using anchor links that point to the same href, as a blank link like href="#" does.

I'd recommend not using a blank href link. I can't preventDefault here because people can use href to link out. I can confirm using an external link wont cause it to re-open before pageload. So this is only a case with anchor tag in page links.

@andrei-piatrou
Copy link
Author

@jlukic JS fiddle is just a sample how to reproduce. I have the same behavior when use regular links in a EmberJS SPA (Single Page Application).

@stale
Copy link

stale bot commented Apr 29, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 29, 2018
@stale stale bot closed this May 29, 2018
@lubber-de

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants