Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing comma: makes 9 global vars local #6136

Merged
merged 1 commit into from
Feb 19, 2018
Merged

Conversation

esbena
Copy link
Contributor

@esbena esbena commented Feb 5, 2018

This PR fixes a simple typo with significant consequences.

The missing colon at the end of line 68 causes implicit semicolon
insertion to happen, this ends the variable declaration statement that
starts on line 67. The nine assignments on the 69-79 then becomes
assignments to global variables.

I found this error with automatic analysis of your project:

https://lgtm.com/projects/g/Semantic-Org/Semantic-UI/snapshot/afe18811db795be24bdb23ca99b22ac2fa948aad/files/tasks/admin/components/init.js?sort=name&dir=ASC&mode=heatmap&excluded=false

You can see more (less serious) errors here: https://lgtm.com/projects/g/Semantic-Org/Semantic-UI/alerts

(full disclosure: I work for lgtm.com)

@championswimmer
Copy link

@jlukic

this needs merging

@jlukic
Copy link
Member

jlukic commented Feb 19, 2018

This should only affect the script used to build the project as an admin to semantic-org. These tasks arent added unless admin flags are set in your semantic.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants