Add font weight global variables #6171
Conversation
|
Heyo!!!! Thank you for getting this in so fast 🙌 Just to ensure I understand how this differs from the original PR.
Thanks again :) |
|
You can now just put in a component's theme variables, i.e. To modify it globally add The general principle is all variables are parsed per component, so you dont have to worry about namespace collisions between components. |
| @headerWeight: bold; | ||
| @headerTextTransform: normal; | ||
| @headerWeight: @bold; | ||
| @headerTextTransform: @normal; |
There was a problem hiding this comment.
@headerTextTransform: @normal;
This is right?
| @@ -285,8 +285,8 @@ | |||
| @tieredActiveItemBackground: #FCFCFC; | |||
| @tieredActiveMenuBackground: #FCFCFC; | |||
|
|
|||
| @tieredSubMenuTextTransform: normal; | |||
| @tieredSubMenuFontWeight: normal; | |||
| @tieredSubMenuTextTransform: @normal; | |||
There was a problem hiding this comment.
@tieredSubMenuTextTransform: @normal;
Text transform shouldn't use font weight value I think.
| @@ -61,8 +61,8 @@ | |||
| @footerColor: @textColor; | |||
| @footerVerticalPadding: @cellVerticalPadding; | |||
| @footerHorizontalPadding: @cellHorizontalPadding; | |||
| @footerFontStyle: normal; | |||
| @footerFontWeight: normal; | |||
| @footerFontStyle: @normal; | |||
There was a problem hiding this comment.
@footerFontStyle: @normal;
Font style using font weight value.
| @@ -152,8 +152,8 @@ | |||
|
|
|||
| @orBackgroundColor: @white; | |||
| @orTextShadow: @invertedTextShadow; | |||
| @orTextStyle: normal; | |||
| @orTextWeight: bold; | |||
| @orTextStyle: @normal; | |||
There was a problem hiding this comment.
@orTextStyle: @normal;
Text style using font weight value.
| @fontWeight: normal; | ||
| @fontStyle: normal; | ||
| @fontWeight: @normal; | ||
| @fontStyle: @normal; |
There was a problem hiding this comment.
@fontStyle: @normal;
Font style using font weight value.
| @dateFontWeight: normal; | ||
| @dateFontStyle: normal; | ||
| @dateFontWeight: @normal; | ||
| @dateFontStyle: @normal; |
There was a problem hiding this comment.
@dateFontStyle: @normal;
Font style using font weight value.
Adds font weight variables ala #6167