Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build Tools] Fixes docs build error from Node's fs #6853

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

whoisryosuke
Copy link

@whoisryosuke whoisryosuke commented Aug 2, 2019

Building docs is broken. This fixes it.

  • Cloned a fresh copy of SUI
  • Ran npm i
  • Ran gulp build-docs and received error.

fs from Node now requires a callback for the third parameter, which was missing from the docs Gulp build task file, causing the gulp build-docs process to break with the following error:

[15:59:18] Starting 'build-docs'...
Building Metadata
Copying examples
Copying LESS source
Building Semantic for docs
(node:72733) [DEP0013] DeprecationWarning: Calling an asynchronous function without callback is deprecated.
fs.js:113
      throw err;  // Forgot a callback but don't know where? Use NODE_DEBUG=fs
      ^

Error: ENOENT: no such file or directory, open '/Users/username/Development/HTML/docs/out/metadata.json'
ITs-MacBook-Pro-6:ksc-ui photoroom$ ./node_modules/gulp/bin/gulp.js build-docs

Adding a simple error callback (with optional console log for error reporting) fixes this issue. Running the docs build process now works.

Not sure if this has already been hashed out for the next release cycle.

`fs` from Node now requires a callback for the third parameter, which was missing from the docs Gulp build task file, causing the `gulp build-docs` process to break with the following error:

```
[15:59:18] Starting 'build-docs'...
Building Metadata
Copying examples
Copying LESS source
Building Semantic for docs
(node:72733) [DEP0013] DeprecationWarning: Calling an asynchronous function without callback is deprecated.
fs.js:113
      throw err;  // Forgot a callback but don't know where? Use NODE_DEBUG=fs
      ^

Error: ENOENT: no such file or directory, open '/Users/username/Development/HTML/docs/out/metadata.json'
ITs-MacBook-Pro-6:ksc-ui photoroom$ ./node_modules/gulp/bin/gulp.js build-docs
```

Adding a simple error callback (with optional console log for error reporting) **fixes this issue**. Running the docs build process now works.

Not sure if this has already been hashed out for the next release cycle.
@whoisryosuke whoisryosuke changed the title 🐛 Fixes docs build error from Node's fs [Build Tools] Fixes docs build error from Node's fs Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants