Remove deprecated mediawiki.api.parse alias
#22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mwjames Since this appears to be only about removing the alias I figured ... |
|
As far as I understood the alias for |
Ah, fair enough. Thanks for the info. |
|
+1 this should be merged.
As I commented before:
- Merge the PR
- Bump the minimum MW requirement to MW 1.31 (README.md, extension.json)
- Change .travis.yml to use REL1_31 as minimum
- Release the changes as 2.1
…On 3/4/19, Tim Groeneveld ***@***.***> wrote:
+1 this should be merged.
@mwjames I am currently running mediawiki 1.33-alpha from git, and the
Mermaid extension does not run without this line being removed, as the alias
is now gone.
I didn't see this pull request until I was making mine. Thanks for your
commit @kghbln!
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#22 (comment)
|
Created #27 for this which I will do during the week. Sit tight please. |
|
@mwjames I believe that we unwillingly dropped support for MW 1.31 with this commit. Thus it needs to be reverted and reintroduced with a shim. Ref: SemanticMediaWiki/SemanticMediaWiki#3626 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #21
Deprecated
mediawiki.api.parsealias will no longer present in MediaWiki 1.33 and later