Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0.0 release #44

Closed
9 tasks done
kghbln opened this issue Nov 28, 2016 · 18 comments
Closed
9 tasks done

2.0.0 release #44

kghbln opened this issue Nov 28, 2016 · 18 comments
Milestone

Comments

@kghbln
Copy link
Member

kghbln commented Nov 28, 2016

@kghbln
Copy link
Member Author

kghbln commented Nov 28, 2016

@kghbln kghbln mentioned this issue Nov 28, 2016
Merged
@kghbln kghbln changed the title Make 2.0.0 release 2.0.0 release Nov 28, 2016
@kghbln
Copy link
Member Author

kghbln commented Nov 28, 2016

I must note that PF must be invoced with wfLoadExtension( 'PageForms' ); even if pulled via Composer else the setup will not work. This is something that must be noted in the README.

@kghbln
Copy link
Member Author

kghbln commented Dec 1, 2016

There was a report that installing it is now working confirming my #44 (comment). Let's see what #45 is about.

@kghbln kghbln added this to the 2.0.0 milestone Dec 1, 2016
@mwjames
Copy link
Contributor

mwjames commented Dec 3, 2016

2.0 contribution notice to include @Seb35, @paladox, and @Rudloff

@mwjames
Copy link
Contributor

mwjames commented Dec 3, 2016

I must note that PF must be invoced with wfLoadExtension( 'PageForms' );

Seeking some advice in https://phabricator.wikimedia.org/T152263.

@kghbln
Copy link
Member Author

kghbln commented Dec 3, 2016

Seeking some advice in https://phabricator.wikimedia.org/T152263.

Given the response it may take too long to wait. I think we should not wait for this to be possible so for the time being a manual loading is the only way out. This extension has created too much momentum to wait longer I guess.

@kghbln
Copy link
Member Author

kghbln commented Dec 3, 2016

2.0 contribution notice to include @Seb35, @paladox, and @Rudloff

Definitely!!

@mwjames
Copy link
Contributor

mwjames commented Dec 3, 2016

Given the response it may take too long to wait. I think we should not wait for this to be possible so for the

Sure, just as reference that I raised the flag on the WMF side.

This was referenced Dec 7, 2016
@kghbln
Copy link
Member Author

kghbln commented Dec 7, 2016

2.0 contribution notice to include @Seb35, @paladox, and @Rudloff

I have just updated the release-notes and the readme so we are getting close to the actual release I believe.

@Seb35
Copy link
Contributor

Seb35 commented Dec 7, 2016

Great, great, great! Thanks for moving forward this step. I’m not sure I can review before Saturday, but Saturday at the latest.

@kghbln
Copy link
Member Author

kghbln commented Dec 10, 2016

If there are no objections I could do the release on Monday

@mwjames
Copy link
Contributor

mwjames commented Dec 10, 2016

If there are no objections I could do the release on Monday

PS: Don't wait for me to merge.

@kghbln
Copy link
Member Author

kghbln commented Dec 10, 2016

PS: Don't wait for me to merge.

Ok, there is nothing which I could possibly break by adding the date to the Release-Notes, at least I hope. :)

@Seb35
Copy link
Contributor

Seb35 commented Dec 11, 2016

Ok, re-tested with MW 1.29, 1.28, 1.27 + SMW 2.4.3 + PF 4.0.2 + SFS 2.0.0.

I opened #52 to warn users in case it does not work.

I have issues with MW 1.28 (the standard request (without JS involved) only shows two empty items instead of one empty and one real); I will try to find why but could you test yourself this specific case? (perhaps I have some wrong thing somewhere)

@kghbln
Copy link
Member Author

kghbln commented Dec 12, 2016

@Seb35 Thanks for the clarification in the README and testing!!

I have issues with MW 1.28 (the standard request (without JS involved) only shows two empty items instead of one empty and one real)

I am not sure if I understand correctly so could try to test this on sandbox which runs MW 1.28. I will now postpone the release.

If there is an issue MW 1.29 this will not be a blocker since it is not officially released yet.

@mwjames
Copy link
Contributor

mwjames commented Dec 17, 2016

I have issues with MW 1.28 (the standard request (without JS involved) only shows two empty items instead of one empty and one real); I will try to find why but could you test yourself this specific case? (perhaps I have some wrong thing somewhere)

I think you guys should make a release otherwise this is going in circles, if a solution is found then making another release/tag shouldn't be that hard.

I quickly went through [0] to see whether the examples work or not (as in changing a value to change a dependency etc.) and it doesn't seem worse of then before.

@Seb35 If you have an example then [1] is the category to go.

[0] https://sandbox.semantic-mediawiki.org/wiki/Semantic_Forms_Select_demo
[1] https://sandbox.semantic-mediawiki.org/wiki/Cat%C3%A9gorie:Semantic_Forms_Select_example

@kghbln
Copy link
Member Author

kghbln commented Dec 17, 2016

I think you guys should make a release otherwise this is going in circles, if a solution is found then making another release/tag shouldn't be that hard.

👍 Ok, will do the release on Monday.

@kghbln
Copy link
Member Author

kghbln commented Dec 19, 2016

All has happened now. I guess having this out is a big progress in comparison to not doing it. Thanks to all of you!

@kghbln kghbln closed this as completed Dec 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants