-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.0.0 release #44
Comments
What about these pulls: |
I must note that PF must be invoced with |
There was a report that installing it is now working confirming my #44 (comment). Let's see what #45 is about. |
Seeking some advice in https://phabricator.wikimedia.org/T152263. |
Given the response it may take too long to wait. I think we should not wait for this to be possible so for the time being a manual loading is the only way out. This extension has created too much momentum to wait longer I guess. |
Sure, just as reference that I raised the flag on the WMF side. |
Great, great, great! Thanks for moving forward this step. I’m not sure I can review before Saturday, but Saturday at the latest. |
If there are no objections I could do the release on Monday |
PS: Don't wait for me to merge. |
Ok, there is nothing which I could possibly break by adding the date to the Release-Notes, at least I hope. :) |
Ok, re-tested with MW 1.29, 1.28, 1.27 + SMW 2.4.3 + PF 4.0.2 + SFS 2.0.0. I opened #52 to warn users in case it does not work. I have issues with MW 1.28 (the standard request (without JS involved) only shows two empty items instead of one empty and one real); I will try to find why but could you test yourself this specific case? (perhaps I have some wrong thing somewhere) |
@Seb35 Thanks for the clarification in the README and testing!!
I am not sure if I understand correctly so could try to test this on sandbox which runs MW 1.28. I will now postpone the release. If there is an issue MW 1.29 this will not be a blocker since it is not officially released yet. |
I think you guys should make a release otherwise this is going in circles, if a solution is found then making another release/tag shouldn't be that hard. I quickly went through [0] to see whether the examples work or not (as in changing a value to change a dependency etc.) and it doesn't seem worse of then before. @Seb35 If you have an example then [1] is the category to go. [0] https://sandbox.semantic-mediawiki.org/wiki/Semantic_Forms_Select_demo |
👍 Ok, will do the release on Monday. |
All has happened now. I guess having this out is a big progress in comparison to not doing it. Thanks to all of you! |
The text was updated successfully, but these errors were encountered: