Add extension.json and a posible fix for composer #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paladox
changed the title
This also may fix composer problem with semanticforms. Please use semanticformsselect.php directly since if you use composer that should load extension.json and load the semanticforms extension. Also add a translatible description. Change-Id: Ic88894768afe30699b5fa3aa4d97450f613fff7e
|
I'm not sure why it keeps failing but the fix should be something like this maybe not extension.json. |
|
Hi could I have help to fix the error. |
| @@ -32,7 +32,15 @@ | |||
| } | |||
| }, | |||
| "autoload": { | |||
| "classmap": [ | |||
There was a problem hiding this comment.
Don't autoloade things from other components! They should do this themselves
| @@ -0,0 +1,22 @@ | |||
| <?php | |||
|
|
|||
| class SemanticFormsSelectHooks { | |||
There was a problem hiding this comment.
Why do I need such class here and especially out of the normal PSR-4 / src directory.
I did not clean-up this extension to see stuff like this (which is common practice in WMF related development) to be floating around.
There was a problem hiding this comment.
So that we can use a callback in extension.json and ExtensionFunctions
|
After just a quick look, I have to say that my opposition on the whole |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.