Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #614 #870

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

D-Groenewegen
Copy link
Contributor

Fix for #614. When no template is used, removes the html (a div element with the 'srf-incoming' class) from the result so that it allows for further reuse.

@gesinn-it-gea
Copy link
Member

Thanks for your PR! At the moment, the changed file is not covered by any tests: https://app.codecov.io/gh/SemanticMediaWiki/SemanticResultFormats/blob/master/formats%2Fincoming%2FSRF_Incoming.php. Do you think you can add some testing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants