Feature/calendar-kiron

[K02D]

My attempt at letting users edit their previous times

[yesterd3v]

Yeah that's a good idea. I'll make this PR ready for review and once James/Sebastian approves we can merge it

Make sure to add us as reviewers!

[K02D]

Oh okay. Sorry about all the notifications! Are you added as a reviewer now?

[RosaGao]

The share button seems to be buggy. I'm not sure if it's only on my computer but the avails didn't show when members are selected and the above error was given.

[K02D]

the avails didn't show when members are selected and the above error was given

Is the app not working like it was in the demo? If not I'll look into the code and see what's going on

[RosaGao]

The concurrently rendering thing is fixed. We would need to wrap setState inside useEffect.

[RosaGao]

Some other issues that we need to consider:

Changes made inside confirm is not save to the app store, so the next time we select that single member wanting to make edits, only the previous selecitons (ones before hitting confirm) will appear in green. But since the changes are post to the api, the changes/edits made through that confirm will show.

If we refresh the page (which is the same as reentering through the shared link), all selections seem to be lost.

[RosaGao]

The app works well like what's in the demo (besides perhaps the confirm part) if we stay on the same page. Also I am a little confused by the purpose changedAlready? If it is only needed inside Calendar it might be changed to a local state rather than a global one

[K02D]

If it is only needed inside Calendar it might be changed to a local state rather than a global one

That's what I did initially but if we use useState() inside Calendar then we'd initialize changedAlready every time Calendar gets rendered, which wouldn't work

The purpose of ChangedAlready is to prevent the infinite re-rending caused by forcibly changing the selection (green cells)

[K02D]

You're right about the Confirm button not working. Hmmm it looks like it's not even working like it was in the demo. I made 1 commit after the demo and that might've broken something. I'll look into it later in the week. Thanks for letting me know

[JJamesWWang]

Since it seems there's an issue, let me know when this is ready for review again

[K02D]

Okay the reason why the app isn't working now but worked during the demo is because my function for converting timeSlots to Date is incorrect (it happened to work for the date of the demo)

[K02D]

@RosaGao I've fixed the problems with Add and Confirm (my conversion function was incorrect). You could have a look and see if everything's working like in the demo!

[RosaGao]

Sounds good!!