Updated EOD reminder to include 2019 Summer RAs and remove ex-RAs #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poftadeh
suggested changes
May 14, 2019
| // Olga: 8:30PM | ||
| // Stuart: 9PM | ||
| // Raymond: 9AM | ||
|
|
||
| // Checks the time to send custom EOD reminders | ||
| const checkTime = (clock) => { | ||
| if (clock.second === 0) { | ||
| if (clock.minute === 0) { |
There was a problem hiding this comment.
This big if-else chain needs refactoring. RA names and messages should also not be hard coded. Consider creating an array of RA objects that have names, reminder times, and messages. Then iterate through that.
poftadeh
approved these changes
May 15, 2019
poftadeh
approved these changes
Jun 3, 2019
belavina
approved these changes
Jun 3, 2019
This was referenced Jun 5, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.