Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port BackToTopButtom from Gatsby to Next.js(TS) #1480

Closed
c3ho opened this issue Dec 3, 2020 · 5 comments · Fixed by #1564
Closed

Port BackToTopButtom from Gatsby to Next.js(TS) #1480

c3ho opened this issue Dec 3, 2020 · 5 comments · Fixed by #1564
Assignees
@joelazwar
Labels
type: enhancement New feature or request

Comments

@c3ho
Copy link
Contributor

c3ho commented Dec 3, 2020

What would you like to be added:
This is an issue to port BackToTopButton from Gatsby to NextJS

Why would you like this to be added:
Part of #1316
@c3ho c3ho added the type: enhancement New feature or request label Dec 3, 2020
@c3ho c3ho self-assigned this Dec 3, 2020
@joelazwar
Copy link
Contributor

If you haven't already, I could help out with porting this if you'd like.

@c3ho c3ho assigned joelazwar and unassigned c3ho Dec 4, 2020
@c3ho
Copy link
Contributor Author

c3ho commented Dec 4, 2020

No worries, I assigned it to you.

@tianlangwu
Copy link
Contributor

isn't this part of #1469? I thought ScrollToTop contains both BackToTopButton and ScrollAction.

@tianlangwu
Copy link
Contributor

I guess I can just do Scroll Action, then you can take BackToTopButton @joelazwar

@joelazwar
Copy link
Contributor

@tianlangwu I think the task list on #1469 is a little outdated, some components are missing/does not exist anymore. It should definitely be updated, but sure I can take the backtotopbutton component for now

This was referenced Dec 7, 2020
Closed
Closed
@humphd humphd mentioned this issue Jan 19, 2021
Merged
4 tasks
tonyvugithub pushed a commit that referenced this issue Jan 20, 2021
@humphd
Fix #1480 Port BackToTopButton from Gatsby to NextJS (#1564)
607a9eb
nilan01 pushed a commit to nilan01/telescope that referenced this issue Jan 20, 2021
@humphd @nilan01
Fix Seneca-CDOT#1480 Port BackToTopButton from Gatsby to NextJS (Sene…
5bd2481 
…ca-CDOT#1564)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joelazwar joelazwar

Labels
type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@c3ho @joelazwar @tianlangwu