Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next] Port AdminButtons/ to NextJS #1494

Closed
tonyvugithub opened this issue Dec 7, 2020 · 4 comments · Fixed by #1619
Closed

[next] Port AdminButtons/ to NextJS #1494

tonyvugithub opened this issue Dec 7, 2020 · 4 comments · Fixed by #1619
Assignees
Labels
area: front-end area: nextjs Nextjs related issues type: enhancement New feature or request

Comments

@tonyvugithub
Copy link
Contributor

tonyvugithub commented Dec 7, 2020

https://github.com/Seneca-CDOT/telescope/tree/master/src/frontend/gatsby/src/components/AdminButtons
What would you like to be added:
Port all components inside AdminButtons/ to NextJS
Why would you like this to be added:
Porting reason

@tonyvugithub tonyvugithub added type: enhancement New feature or request area: front-end area: nextjs Nextjs related issues labels Dec 7, 2020
@sonechca
Copy link
Contributor

Hi Tony,

I ported the admin button to Next.Js and added PR
Can you check my PR? let me know if I need to fix more
Thank you :)

@sonechca sonechca linked a pull request Dec 11, 2020 that will close this issue
8 tasks
@tonyvugithub
Copy link
Contributor Author

I don't think they plan on accepting any PR now. They want to have some discussions before doing so I think. Someone like @manekenpix or @humphd might be able to answer you better

@sonechca
Copy link
Contributor

Ok I am gonna ask them. Thank you, Tony :)

@tonyvugithub
Copy link
Contributor Author

@sonechca : is there any update on this? We are waiting on this as it is a dependent component for some others.

yuanLeeMidori added a commit that referenced this issue Jan 29, 2021
* Port adminbutton to next

* Add condition to avoid undefined return
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: front-end area: nextjs Nextjs related issues type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants