Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[auth] Improve how we define admin accounts #1868

Closed
humphd opened this issue Mar 5, 2021 · 1 comment · Fixed by #2344
Closed

[auth] Improve how we define admin accounts #1868

humphd opened this issue Mar 5, 2021 · 1 comment · Fixed by #2344
Assignees
Labels
area: back-end area: deployment Production or Staging deployment area: microservices type: enhancement New feature or request type: security Security concerns

Comments

@humphd
Copy link
Contributor

humphd commented Mar 5, 2021

In #1796, we are defining admin accounts via an env variable with ADMINISTRATORS being passed in. This is probably OK for one super-admin, but the rest can be defined in Firebase with the #1642 (cc @chrispinkney).

@humphd
Copy link
Contributor Author

humphd commented Oct 8, 2021

I don't think we're using the ADMINISTRATORS env stuff at all in the auth service. We do in the old backend, see

const administrators = process.env.ADMINISTRATORS ? process.env.ADMINISTRATORS.split(' ') : [];
.

Let's add it to the auth service as well, so we can bootstrap a few super-user admins into the system without the chicken-and-egg problem of database access.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: back-end area: deployment Production or Staging deployment area: microservices type: enhancement New feature or request type: security Security concerns
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants