Closes #552: Remove GraphQL implementation

[manekenpix]

Issue This PR Addresses

Closes #552
Progress towards #1224
Progress towards #1225

Type of Change

Description

This removes the graphql implementation and documentation. Since removing graphql breaks the search functionality for author, I made some changes so the front-end uses the same endpoint to search both authors and posts, taking advantage of what was added in #1280.

Other changes:

• Entering input doesn't trigger a search, only hitting enter or clicking on the search icon (this is part of Reposition search button for search UI #1225)
• Searching for author returns posts by that author(s), instead of the author card. Sorting the returned posts could be addressed in Show all posts for an author sorted by date when searching by Author #1224
• The filter in the search page is now set to post by default.

Checklist

• Quality: This PR builds and passes our npm test and works locally
• Tests: This PR includes thorough tests or an explanation of why it does not
• Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
• Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

[c3ho]

I'll review this tomorrow. I saved a branch of our current Telescope in case I need to remember some GraphQL stuff!

[cindyorangis]

I tested this locally using Docker on Windows.
I was able to search for posts using the search button. As mentioned, searching using the Author filter doesn't work.

This PR doesn't fully remove all GraphQL from Telescope. There are still bits of it in our
Banner, my poorly implemented About page (it has graphql in multiple places unfortunately)
https://github.com/Seneca-CDOT/telescope/blob/master/src/frontend/src/templates/template.js
https://github.com/Seneca-CDOT/telescope/blob/master/src/frontend/gatsby-node.js.

I was surprised that none of the other components broke in this PR

[manekenpix]

@cindyledev

I was able to search for posts using the search button. As mentioned, searching using the Author filter doesn't work

I just tested it searching by Author and it works. Can you tell me what to do to reproduce your results?

This PR doesn't fully remove all GraphQL from Telescope

This is intentional. The graphql pieces left in the front-end are necessary to build pages (I think gatsby needs it) or to fetch metadata. In both cases, they don't talk to the graphql server in the back-end, which is what was removed in this PR.

[humphd]

This is awesome, thanks for doing it, and sorry to throw away all the good work you, @c3ho and others did. It was great to experiment with this.

Do we still need to do scriptSrc: ["'self'", 'cdn.jsdelivr.net', "'unsafe-inline'"], in the express app if we rip out the graphql playground (the cdn I mean)?

[humphd]

This comment seems wrong, we pass post ids, no?

Also, I think we should do this transform from {id} to {id, url} on the server, either in this PR or another. Let's prepare the results to be useful right away from the REST api. I actually thought we were doing this in another PR, which might still be in review? cc @c3ho.

[c3ho]

I think we merged all new ES related PRs last week. I checked the code and we don't store feedID at least from what I see

[manekenpix]

I'll change this. I mainly deleted what's not needed anymore but I didn't really pay much attention to the code that's going to stay.
Also, I think the backend already sends {id, url} (I think it's like this since the very beginning of telescope) it does it here, so I'll remove the transform (sorry about that, again I just deleted stuff without putting too much attention on what's going to stay).

[humphd]

Awesome, thank you both for looking into this. I'm reviewing this code again since we're touching it; sorry to make work for you @manekenpix. We can file follow-ups on anything we find vs. delaying this surgery from being completed.

[manekenpix]

My bad, the endpoint returning {id, url} is GET /posts, not the one used for searching. I just changed the indexer to return the same thing, and removed the transformation from the front-end.

[c3ho]

Tested:
Confirmed search was not firing after onChange
Confirmed default search is Post
Confirmed search results by searching Telescope for Post and James for Author only authors with James in their name were displayed

[humphd]

Awesome.