Issue 1366 - Slack integrations [ Siblings Check ] #1530

PedroFonsecaDEV · 2020-12-13T03:13:04Z

Issue This PR Addresses

Type of Change

Bugfix: Change which fixes an issue
New Feature: Change which adds functionality
Documentation Update: Change which improves documentation
UI: Change which improves UI

Description

This PR is part of the solution of #1366.
Siblings Checkers: DEV and PROD checking each other periodically.

We also have an internal checker:
Slack Integration: Docker Events

Checklist

Quality: This PR builds and passes our npm test and works locally
Tests: This PR includes thorough tests or an explanation of why it does not
Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

PedroFonsecaDEV · 2020-12-13T03:19:52Z

Obs: We need to change the message.

manekenpix

It looks good, just a few nits. We'll need a teams/zoom session to test this.

manekenpix · 2021-01-16T20:38:55Z

tools/autodeployment/env.example

+#       body: "text": "This is the message"
+#     });
+# This will send the following message to our Slack channel: "This is the message"
+SLACK_SEND_MESSAGE=


I'm not sure of what this means. Is SLACK_SEND_MESSAGE the text that will be sent to the channel?
Also, I don't think you need to show an example here, the URL to webhooks should be enough.

Example requested by @humphd:
#1472 (comment)

SLACK_SEND_MESSAGE is an URL that receives a fetch/post with the message as the body and publishes it on our slack channel. It's almost like an API KEY, everyone with this URL will be able to send messages to our slack channel.

I still think the example should go in the docs, where all the env vars are explained.

Sure, you are right. We should add them to this doc too.

If this is a URL, let's label it as such. I think @manekenpix's confusion is partly due to the name. What about SLACK_WEBHOOK_URL instead?

manekenpix · 2021-01-16T20:39:20Z

tools/autodeployment/server.js

+// Server health check
+
+firstCheck();


You could just call it healthCheck()

Sure. It will make more sense in this scope.

tools/autodeployment/src/sibling-checker/index.js

manekenpix · 2021-01-16T20:57:58Z

tools/autodeployment/src/sibling-checker/index.js

+  process.DEPLOY_TYPE === 'production'
+    ? 'https://telescope.cdot.systems/health.'
+    : 'https://dev.telescope.cdot.systems/health.';


We could do here what @humphd suggested. We can make the servers check each other, so if the machine is down, we'd still get the status, but I think that you'd need to add a case in which the server never answers.

I will sketch this feature. I think it will be better to understand it. But basically, we have the firstCheck running every 2 min. If the firstCheck fails, it will trigger the secondCheck that stops the firstCheck and performs a fetch every 10sec. If the secondCheck fails for the first time, the message "SERVER DOWN" is sent to us on SLACK. Once the message is sent, the secondCheck continues to run (the message informing us about the crash is sent just once). When the server is back, secondCheck sends the message "SERVER IS BACK", stop itself and triggers the firstCheck.

Because we rely on the network, sometimes the firstCheck can emit a false-negative when it fails due to network "issues" (timeout, etc.). That's why I created this system to double-check the server and try to avoid false-negative messages on our slack channel.

PedroFonsecaDEV · 2021-01-17T02:46:46Z

@manekenpix

It looks good, just a few nits. We'll need a teams/zoom session to test this.

Sure. Let's do it.

PedroFonsecaDEV · 2021-01-17T04:13:14Z

@manekenpix @humphd

humphd

Looking better and better. I agree, let's get on a call early this week and test it together. Let's co-ordinate on Slack when these changes are done and we can test for real.

humphd · 2021-01-17T16:25:58Z

tools/autodeployment/env.example

+#       body: "text": "This is the message"
+#     });
+# This will send the following message to our Slack channel: "This is the message"
+SLACK_SEND_MESSAGE=


If this is a URL, let's label it as such. I think @manekenpix's confusion is partly due to the name. What about SLACK_WEBHOOK_URL instead?

humphd · 2021-01-17T16:26:40Z

tools/autodeployment/src/sibling-checker/index.js

@@ -0,0 +1,81 @@
+/* eslint-disable no-use-before-define */
+/* eslint-disable no-unused-expressions */


Are these really necessary? Can we not change your code to fit our linting style?

Regarding the /* eslint-disable no-unused-expressions */ is solved.

But regarding /* eslint-disable no-use-before-define */
I have tried until I run out of ideas.

Because the firstCheck calls the secondCheck and vice versa.

const a = () => { b(); -> LINTER: "b" was used before it was defined. } const b = () => { a() }

Any idea about this is welcome.

humphd · 2021-01-17T16:27:44Z

tools/autodeployment/src/sibling-checker/index.js

+      clearIntervalAsync(timerOne);
+      secondCheck();
+    }
+  }, 120000);


All these magic numbers should probably be something we can configure via env.

humphd · 2021-01-17T16:28:40Z

tools/autodeployment/src/sibling-checker/index.js

+          image_url:
+            status === 200
+              ? 'https://data.whicdn.com/images/186936913/original.jpg'
+              : 'https://64.media.tumblr.com/090e86896948354262566ddb906e514e/tumblr_mxrsfhStH61r62zwpo1_500.jpg',


Should we pull images we depend on into our repo so we can rely on the URLs not going down in the future?

Sure, this is just a test message.

tools/autodeployment/src/sibling-checker/index.js

tools/autodeployment/server.js

Metropass · 2021-01-19T16:04:20Z

This is very cool, might I add a suggestion?

I know this is bare bones at the moment, but I was wondering if we can write the status of the server into a .txt file

It might be a bit easier on the eyes, and it'll help archive the logs from the server

PedroFonsecaDEV · 2021-01-20T07:48:38Z

This is very cool, might I add a suggestion?

I know this is bare bones at the moment, but I was wondering if we can write the status of the server into a .txt file

It might be a bit easier on the eyes, and it'll help archive the logs from the server

Could you please elaborate more?

PedroFonsecaDEV · 2021-01-20T07:50:02Z

I'm updating the images because I'm not sure about the license of the previous images.

Fixes Seneca-CDOT#1815: Spotify playlists within an iframe are not sanitized

izhuravlev · 2021-02-23T15:14:56Z

Thank you very much to everyone committing to this PR, your work is very appreciated.

We will be coming back to this PR later, so we are closing it for now.

in the server entry point. And REBASE

*fix env access on Siblings Check module *docs updated

order prod checking dev and vice versa

PedroFonsecaDEV · 2021-02-24T07:26:32Z

Sorry, I will reopen this PR for testing purposes.

PedroFonsecaDEV · 2021-02-24T07:32:51Z

Okay tested. Sorry.

vercel bot deployed to Preview December 13, 2020 03:13 View deployment

PedroFonsecaDEV requested review from humphd and manekenpix December 13, 2020 03:13

PedroFonsecaDEV self-assigned this Dec 13, 2020

PedroFonsecaDEV added type: enhancement New feature or request type: nice to have Feature that'd be nice to have, but not a priority area: tools area: deployment Production or Staging deployment labels Dec 13, 2020

PedroFonsecaDEV linked an issue Dec 13, 2020 that may be closed by this pull request

Investigate Slack integrations for failed or successful builds #1366

Open

manekenpix requested changes Jan 16, 2021

View reviewed changes

manekenpix reviewed Jan 16, 2021

View reviewed changes

humphd requested changes Jan 17, 2021

View reviewed changes

PedroFonsecaDEV changed the title ~~Issue 1366 - Slack integrations [ Siblings Checker ]~~ Issue 1366 - Slack integrations [ Siblings Check ] Jan 18, 2021

vercel bot deployed to Preview January 18, 2021 08:22 View deployment

PedroFonsecaDEV requested review from manekenpix and humphd January 18, 2021 08:27

PedroFonsecaDEV commented Jan 18, 2021

View reviewed changes

tools/autodeployment/server.js Show resolved Hide resolved

vercel bot deployed to Preview January 20, 2021 07:47 View deployment

c3ho added 4 commits January 20, 2021 09:57

missing check

e3adc78

Added spinner as well to PR

e458ca8

fix export

1001629

resolving swr issues

d563070

HyperTHD added 2 commits February 22, 2021 19:50

Included cdn.embedly.com test

abe5edc

Merge pull request Seneca-CDOT#1817 from HyperTHD/issue-1815

aff6aa0

Fixes Seneca-CDOT#1815: Spotify playlists within an iframe are not sanitized

izhuravlev closed this Feb 23, 2021

humphd and others added 18 commits February 23, 2021 15:09

Change traefik to use /v1/service-name URLs vs. subdomains

50ebb7e

node-fetch and env.example

fc11172

packages

9824fc4

rebase feb 24

b54a59f

Update env variable name to SLACK_WEBHOOK_URL

4eea55b

docs updated

5814703

firstCheck import as healthCheck

66224b3

in the server entry point. And REBASE

linter check for unused expressions

9f47c25

*checkers timers to env file

02135d6

*fix env access on Siblings Check module *docs updated

add image to doc

124d21d

images update

9553557

continue

3041f16

test

815fae0

*fixing urls:

9f00714

order prod checking dev and vice versa

update MD

518ff89

rename firstCheck to healthCheck

2db134a

Update env.example and code

8aba7af

add alt text

11b5313

PedroFonsecaDEV reopened this Feb 24, 2021

vercel bot deployed to Preview February 24, 2021 07:26 View deployment

PedroFonsecaDEV closed this Feb 24, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue 1366 - Slack integrations [ Siblings Check ] #1530

Issue 1366 - Slack integrations [ Siblings Check ] #1530

PedroFonsecaDEV commented Dec 13, 2020

PedroFonsecaDEV commented Dec 13, 2020 •

edited

Loading

manekenpix left a comment

manekenpix Jan 16, 2021

PedroFonsecaDEV Jan 17, 2021

manekenpix Jan 17, 2021

PedroFonsecaDEV Jan 17, 2021

humphd Jan 17, 2021

manekenpix Jan 16, 2021

PedroFonsecaDEV Jan 16, 2021

manekenpix Jan 16, 2021

PedroFonsecaDEV Jan 17, 2021

PedroFonsecaDEV commented Jan 17, 2021

PedroFonsecaDEV commented Jan 17, 2021

humphd left a comment

humphd Jan 17, 2021

humphd Jan 17, 2021

PedroFonsecaDEV Jan 18, 2021 •

edited

Loading

humphd Jan 17, 2021

humphd Jan 17, 2021

PedroFonsecaDEV Jan 18, 2021

Metropass commented Jan 19, 2021

PedroFonsecaDEV commented Jan 20, 2021

PedroFonsecaDEV commented Jan 20, 2021

izhuravlev commented Feb 23, 2021

PedroFonsecaDEV commented Feb 24, 2021

PedroFonsecaDEV commented Feb 24, 2021

		@@ -0,0 +1,81 @@
		/* eslint-disable no-use-before-define */
		/* eslint-disable no-unused-expressions */

Issue 1366 - Slack integrations [ Siblings Check ] #1530

Issue 1366 - Slack integrations [ Siblings Check ] #1530

Conversation

PedroFonsecaDEV commented Dec 13, 2020

Issue This PR Addresses

Type of Change

Description

Checklist

PedroFonsecaDEV commented Dec 13, 2020 • edited Loading

manekenpix left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PedroFonsecaDEV commented Jan 17, 2021

PedroFonsecaDEV commented Jan 17, 2021

humphd left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PedroFonsecaDEV Jan 18, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Metropass commented Jan 19, 2021

PedroFonsecaDEV commented Jan 20, 2021

PedroFonsecaDEV commented Jan 20, 2021

izhuravlev commented Feb 23, 2021

PedroFonsecaDEV commented Feb 24, 2021

PedroFonsecaDEV commented Feb 24, 2021

PedroFonsecaDEV commented Dec 13, 2020 •

edited

Loading

PedroFonsecaDEV Jan 18, 2021 •

edited

Loading