Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1534, added legacy-peer-deps option set to true #1617

Closed
wants to merge 8 commits into from

Conversation

Metropass
Copy link
Contributor

@Metropass Metropass commented Jan 27, 2021

Issue This PR Addresses

Type of Change

Fixes #1534

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

As of npm7.x, Peer Dependencies has had an overhaul, causing some of our dependencies not properly installing if a user runs npm install. This is a band-aid fix to use the legacy Peer Dependencies, until we fix the issue for forwards compatibility.

More Information on the Changes of Peer Dependencies can be found here

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@Metropass
Copy link
Contributor Author

Saved as a draft for now, due to my other PR not being merged yet.

Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase this on master, and drop the other changes in here? Then we could land it separate to your FRONTEND fix.

.npmrc Outdated
# Use exact versions of dependencies vs. semver minor updates
save-exact=true

# Allow running postinstall script in Docker
unsafe-perm=true

# Allows users of npm7.x to properly build Telescope without breaking. Uses old npm6.x peer dependency installation
legacy-peer-deps=true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a newline after this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do! I'll also rebase to master so that we can clean things up a bit.

Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still isn't right @Metropass, can you please rebase this properly so you only have 1 commit and have it be off of master?

If you need help, please talk with folks on slack

@Metropass
Copy link
Contributor Author

Closed, as this PR is very outdated. See #1694 as it's a cleaner version and rebased

@Metropass Metropass closed this Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node Version 15+ Does Not Install Dependecies Properly
2 participants