-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #1534, added legacy-peer-deps
option set to true
#1617
Conversation
Saved as a draft for now, due to my other PR not being merged yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rebase this on master, and drop the other changes in here? Then we could land it separate to your FRONTEND fix.
.npmrc
Outdated
# Use exact versions of dependencies vs. semver minor updates | ||
save-exact=true | ||
|
||
# Allow running postinstall script in Docker | ||
unsafe-perm=true | ||
|
||
# Allows users of npm7.x to properly build Telescope without breaking. Uses old npm6.x peer dependency installation | ||
legacy-peer-deps=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a newline after this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do! I'll also rebase to master so that we can clean things up a bit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still isn't right @Metropass, can you please rebase this properly so you only have 1 commit and have it be off of master
?
If you need help, please talk with folks on slack
Closed, as this PR is very outdated. See #1694 as it's a cleaner version and rebased |
Issue This PR Addresses
Type of Change
Fixes #1534
Description
As of npm7.x, Peer Dependencies has had an overhaul, causing some of our dependencies not properly installing if a user runs
npm install
. This is a band-aid fix to use the legacy Peer Dependencies, until we fix the issue for forwards compatibility.More Information on the Changes of Peer Dependencies can be found here
Checklist