[next] Fixes #1484: Re-Adds the Search page component #1621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrispinkney
requested review from
huyxgit,
c3ho,
rjayroso,
yuanLeeMidori,
tonyvugithub and
PedroFonsecaDEV
chrispinkney
changed the title
8 tasks
tonyvugithub
previously requested changes
Feb 4, 2021
c3ho
previously approved these changes
Feb 4, 2021
|
Looks like Darkmode will need to be fixed for Searchpage. When this lands we'll have to open another issue for that. |
c3ho
approved these changes
Feb 4, 2021
humphd
approved these changes
Feb 5, 2021
| <> | ||
| <Head> | ||
| <title>Search</title> | ||
| <meta property="og:title" content="Telescope" key="title" /> |
There was a problem hiding this comment.
This isn't dong anything there, let's remove and have it happen in _document.tsx
izhuravlev
pushed a commit
to izhuravlev/telescope
that referenced
this pull request
Feb 5, 2021
…eca-CDOT#1621) * Added Search component and moved search.tsx contents to SearchPage component * Added Head, Darkmode Toggle, and Banner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue This PR Addresses
Fixes #1484
Type of Change
Description
This PR adds
search.tsx, a page which will render the<SearchPage />component. It also injects SEO along with the banner and head components.EDIT: The
<SearchPage />component was just land-ho'd, so I merged master into this PR, renamed thesearch.tsxcomponent @c3ho toSearchPage, added SEO to our search page, the banner, head, and darkmode toggle button.Just waiting on<SearchPage />to be finished then I can test this further.CI/CD will fail as the<SearchPage />component isn't yet implemented, when it gets released I'll (try to remember to) come back and test this further.How to test
Pull the PR and navigate to http://localhost:8000/search.
Checklist