Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: issue 1588 - Update bull board and highlight.js dep #1768

Merged
merged 1 commit into from
Feb 17, 2021
Merged

Fix: issue 1588 - Update bull board and highlight.js dep #1768

merged 1 commit into from
Feb 17, 2021

Conversation

yuanLeeMidori
Copy link
Contributor

@yuanLeeMidori yuanLeeMidori commented Feb 17, 2021 •
edited
Loading

Issue This PR Addresses

Fixes: #1588
Related: #1592

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

bull-board 0.9.0 has highlight version 9 dependency. To fix issue #1588, we need to update bull-board.

image

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@yuanLeeMidori yuanLeeMidori added this to the 1.7 Release milestone Feb 17, 2021
@yuanLeeMidori yuanLeeMidori self-assigned this Feb 17, 2021
@yuanLeeMidori yuanLeeMidori changed the title Update bull board Fix: issue 1588 - Update bull board and highlight dep Feb 17, 2021
@yuanLeeMidori yuanLeeMidori changed the title Fix: issue 1588 - Update bull board and highlight dep Fix: issue 1588 - Update bull board and highlight.js dep Feb 17, 2021
@birtony
Copy link
Contributor

birtony commented Feb 17, 2021 •
edited
Loading

highlight.js is already updated @yuanLeeMidori :)

birtony
birtony approved these changes Feb 17, 2021
View reviewed changes
Copy link
Contributor

@birtony birtony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@birtony birtony added the dependencies Pull requests that update a dependency file label Feb 17, 2021
humphd
humphd previously approved these changes Feb 17, 2021
View reviewed changes
birtony
birtony suggested changes Feb 17, 2021
View reviewed changes
Copy link
Contributor

@birtony birtony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuanLeeMidori you need to do a rebase instead of merging the master branch in, please

@yuanLeeMidori
Copy link
Contributor Author

@birtony sorry, I didn't wanna dismiss the reviews so I use rebase button on github UI. Should I do rebase on my local instead?

@birtony birtony merged commit 21d4c4d into Seneca-CDOT:master Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@birtony birtony birtony approved these changes

@chrispinkney chrispinkney chrispinkney approved these changes

@manekenpix manekenpix Awaiting requested review from manekenpix

@humphd humphd Awaiting requested review from humphd

@c3ho c3ho Awaiting requested review from c3ho

@huyxgit huyxgit Awaiting requested review from huyxgit

@HyperTHD HyperTHD Awaiting requested review from HyperTHD

@izhuravlev izhuravlev Awaiting requested review from izhuravlev

@Metropass Metropass Awaiting requested review from Metropass

@PedroFonsecaDEV PedroFonsecaDEV Awaiting requested review from PedroFonsecaDEV

@raygervais raygervais Awaiting requested review from raygervais

@rjayroso rjayroso Awaiting requested review from rjayroso

@tonyvugithub tonyvugithub Awaiting requested review from tonyvugithub

Assignees

@yuanLeeMidori yuanLeeMidori

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
1.7 Release
Development

Successfully merging this pull request may close these issues.

Update highlight.js
4 participants
@yuanLeeMidori @birtony @humphd @chrispinkney