-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add microservices status page link to main page #2356
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool! A few things I notice.
README.md
Outdated
@@ -2,6 +2,7 @@ | |||
|
|||
[![js-airbnb/prettier-style](https://img.shields.io/badge/code%20style-airbnb%2Fprettier-blue)](https://github.com/airbnb/javascript) | |||
![Node.js CI](https://github.com/Seneca-CDOT/telescope/workflows/node-js-ci/badge.svg) | |||
[![Status](https://img.shields.io/badge/Status-informational)](https://api.telescope.cdot.systems/v1/status) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's change this text to API Status
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add dev
's status as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, good idea. @dbelokon let's add two of these badges:
- Prod API Status - https://api.telescope.cdot.systems/v1/status
- Dev API Status - https://dev.api.telescope.cdot.systems/v1/status
Hello!! I have completed the requested changes. Let me know if there is anything else needed😁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic. Almost done.
README.md
Outdated
@@ -2,6 +2,8 @@ | |||
|
|||
[![js-airbnb/prettier-style](https://img.shields.io/badge/code%20style-airbnb%2Fprettier-blue)](https://github.com/airbnb/javascript) | |||
![Node.js CI](https://github.com/Seneca-CDOT/telescope/workflows/node-js-ci/badge.svg) | |||
[![Prod. API Status](https://img.shields.io/badge/Prod._API_Status-informational)](https://api.telescope.cdot.systems/v1/status) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's drop the periods: Prod
and Dev
are good.
src/web/src/components/Banner.tsx
Outdated
@@ -191,6 +198,9 @@ export default function Banner({ onVisibilityChange }: BannerProps) { | |||
</Typography> | |||
</div> | |||
<div className={classes.icon}> | |||
<a className={classes.infoIcon} href="https://api.telescope.cdot.systems/v1/status"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a title="API Status"
attribute here for an info popup.
Done and done 😎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@manekenpix you want these two badges on a new line? |
@humphd yes, I think it'd look better |
Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me.
Looking great, it just needs a rebase and it's good to go 👍 |
Okay, I almost broke my local branch! 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dbelokon despite whatever issues you had getting this rebased, you did it! Well done 🥳
Hurrayyy🥳🥳 thank you for everything @humphd 😎 |
Issue This PR Addresses
Fixes #2347
Type of Change
Description
This PR adds an informational icon on the left to the version number so we can easily access the status of the micro-services by clicking on that icon. It also updates the README file with a status icon linking to the same page.
Checklist