-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Gitpod configuration #2406
Conversation
@humphd, @cindyledev |
It sounds like we might want to create a separate env config for docker-compose running in gitpod, which would be similar to dev or staging. Then we can override this stuff and not affect the rest. Why don't you create |
It looks like we can't configre I'll try to map ports to URLs in |
I'm saying something slightly different. You'd have 2 or 3 files:
|
I made a branch off this one to test it. I was able to get port 8000 to fetch local data https://github.com/cindyledev/telescope/tree/issue_2393_b Unsure if I should or if I'm allowed to push commits to this branch. To test out my branch, just click on the |
There are a number of things I want to test but cannot do it today as it is Halloween but I can probably get to it tomorrow. For example, I don't think we need to open so many ports, I think we only need to open up ports 3000 and 8000. And it seems like prebuild runs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File a follow-up issue to deal with getting this to work properly for the gitpod URL, and then we can take this.
Rebasing |
@manekenpix can you take a quick look at the changes to the development/production docker files? I think this is fine, but before we merge, I want your OK. We'll get this perfected in a follow-up, but i don't want to break dev/staging/production in the meantime. Basically, you can't set ulimits in gitpod's security context (you're running docker in docker), so we need to not do this in the base config. |
OK, discussed this with @manekenpix on Slack, and I think we're good to go with this. I'll merge. |
Fixes #2393
https://www.gitpod.io/docs/getting-started#start-your-first-workspace
Issue This PR Addresses
Type of Change
Description
Checklist