-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 1974: Student Quotes #2422
Issue 1974: Student Quotes #2422
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think added in italics to the quote instead of the author might look better, and agreed with Pedro the space between the quote and the author will make it magnificent.
What are your thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Looks good! |
Issue This PR Addresses
Fixes #1974
Type of Change
Description
I have added a temporary JSON in a file called student-quotes.js with some quotes that struck out to peers in the issue and I. In the Banner.tsx file I have added functionality to pick a random quote and display it on the home page in the banner. When you click on the student's name, it is redirected to the blog link for the quote.
Checklist