Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1974: Student Quotes #2422

Merged

Conversation

AmasiaNalbandian
Copy link
Contributor

Issue This PR Addresses

Fixes #1974

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

I have added a temporary JSON in a file called student-quotes.js with some quotes that struck out to peers in the issue and I. In the Banner.tsx file I have added functionality to pick a random quote and display it on the home page in the banner. When you click on the student's name, it is redirected to the blog link for the quote.

chrome_VuKOGJDFtT
chrome_OjT6LZnfX9

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

Copy link
Contributor

@PedroFonsecaDEV PedroFonsecaDEV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a space between the quote and the author name would be a good idea.
Also not sure about the i tag.

I would go to with something like this:
Screen Shot 2021-10-30 at 8 07 43 PM

@Grommers00 Grommers00 self-requested a review October 31, 2021 00:23
Copy link
Contributor

@Grommers00 Grommers00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think added in italics to the quote instead of the author might look better, and agreed with Pedro the space between the quote and the author will make it magnificent.

What are your thoughts?

@AmasiaNalbandian
Copy link
Contributor Author

AmasiaNalbandian commented Oct 31, 2021

I think added in italics to the quote instead of the author might look better, and agreed with Pedro the space between the quote and the author will make it magnificent.

What are your thoughts?

This is how it looks italisized:
image

image

and without italics:
image

Copy link
Contributor

@PedroFonsecaDEV PedroFonsecaDEV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Grommers00
Copy link
Contributor

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use quotes from former students about open source on front page
4 participants