Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 3747: Fixed all links use purple, even if not visited #3752

Merged

Conversation

AmasiaNalbandian
Copy link
Contributor

@AmasiaNalbandian AmasiaNalbandian commented Nov 1, 2022

Issue This PR Addresses

Fixes #3747

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

Changed the color of the links presented on the blogs from purple, to the original blue used globally on the net.

Please see below for unvisited colors:
Dark mode:
chrome_yAKJGtcGrC

Light Mode:
chrome_mh8JMnZUaT

Note: Visited links remain the same as below:
chrome_T5ZAKYi6RF

chrome_kXwF8EwQU9

Steps to test the PR

  1. Run pnpm i
  2. Copy .env for front-end cp config/env.staging .env
  3. pnpm dev to start
  4. Change between light and dark mode make sure the links look as per attached images(blue font)

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@AmasiaNalbandian AmasiaNalbandian added type: bug Something isn't working area: front-end area: accessibility Making Telescope accessible for all kinds of users labels Nov 1, 2022
@AmasiaNalbandian AmasiaNalbandian self-assigned this Nov 1, 2022
@gitpod-io
Copy link

gitpod-io bot commented Nov 1, 2022

Copy link
Member

@manekenpix manekenpix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

New:
image

Visited:
image

@AmasiaNalbandian AmasiaNalbandian merged commit 99cd75e into Seneca-CDOT:master Nov 1, 2022
liutng pushed a commit to liutng/telescope that referenced this pull request Nov 21, 2022
…le (Seneca-CDOT#3752)

Co-authored-by: AmasiaNalbandian <a.nalbandian@live.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: accessibility Making Telescope accessible for all kinds of users area: front-end hacktoberfest-accepted type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All links use purple, even if not visited
2 participants