Skip to content

fix: remove package manager from vscode settings #3770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2022

Conversation

manekenpix
Copy link
Member

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

This PR removes the line in our settings.json where pnpm was set as the project's package manager.
This line was causing the vscode extension for eslint to fail for some users:

image

My guess is that it's related to using nvm instead of a traditional nodejs installation. The vscode repo has an issue about this, and it seems that a solution that seems to work is what's added in this PR.

Steps to test the PR

  • Check if this issue affects you by checking the output window (not the terminal) in vscode. If you see the error message, this affects you
  • Check out the branch used in this PR
  • Assert that linter errors are detected in vscode.

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@manekenpix manekenpix added the developer experience Helping the Developer Experience label Nov 19, 2022
@manekenpix manekenpix requested a review from humphd November 19, 2022 18:51
@manekenpix manekenpix self-assigned this Nov 19, 2022
@gitpod-io
Copy link

gitpod-io bot commented Nov 19, 2022

Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tracking this down

@manekenpix manekenpix merged commit 1fe74d8 into Seneca-CDOT:master Nov 20, 2022
@manekenpix manekenpix deleted the fix-vscode-config branch November 20, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer experience Helping the Developer Experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants