Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Korean translation for the About page #3836

Merged
merged 7 commits into from
Oct 9, 2023

Conversation

avelynhc
Copy link
Contributor

@avelynhc avelynhc commented Sep 19, 2023

Fixes #3835 and #2962

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

This PR is a Korean translation for the about page in Telescope.

Screenshot 2023-09-19 at 5 57 42 PM Screenshot 2023-09-19 at 5 58 54 PM Screenshot 2023-09-19 at 5 59 30 PM

Steps to test the PR

  • Change the current directory to src/web/docusaurus/i18n/ko/docusaurus-plugin-content-docs/current/
  • Run npm run start -- --locale ko
  • Docusaurus website will be running at: http://localhost:4631/docs/ko/
  • Click the 'Docs' button in the top left corner

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@avelynhc
Copy link
Contributor Author

@TueeNguyen I just pushed the pr. I will try to find another Korean reviewer for this pr.

## 소개

세네카 대학의 오픈 소스 참여의 핵심 기능 중 하나는 우리가 작업하고 가르치고 블로그를 통해 학습하는 것에 중점을 둔 것입니다.
오픈 소스 커뮤니티에서 일하는 방법을 배우는 것이 가장 보람있는 부분 중 하나는

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translation of this sentence is awkward. I can understand the intent of the sentence, but the grammar is awkward.

Copy link
Contributor Author

@avelynhc avelynhc Sep 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a change to "세네카 대학의 오픈 소스 참여의 핵심 특징 중 하나는 우리가 하는 일을 공유하고, 블로그를 통해 가르치고 또 배우는 것 입니다.".

또한, 우리가 오픈 소스를 통해 함께 한 결과를 위해 Planet이 필요하다고 생각하기 때문에,
_오픈 소스 함께 하기_ 를 만드는 것이 가장 바람직한 길이라고 생각합니다.

## 우리의 Planet을 정의하려는 시도

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the word "시도" was used that didn't match the context.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to "우리의 Planet을 정의하려는 노력" as I translated "try" to "노력"

오픈 소스 커뮤니티에서 일하는 방법을 배우는 것이 가장 보람있는 부분 중 하나는
한 사람이 웹의 일부가 되고 목소리를 내며 팔로잉을 구축할 수 있다는 것을 발견하는 것 입니다.
우리는 또한 서로의 블로그 글을 읽는 것이 중요하다고 생각합니다.
동료들의 블로그 글에서 우리는 일이 돌아가도록 노력하는 사람이 나 혼자가 아니라는 것, 다양한 주제에 대한 우리의 관심,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word "돌아가다" is not formal word when it's used with the word "일" or the word that meaning "work" in formal website.

Copy link
Contributor Author

@avelynhc avelynhc Sep 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to "동료들의 블로그 글에서 우리는 일이 잘되게 노력하는 사람이 우리만이 아니라는 것, 다양한 주제에 대한 우리의 관심...". I made a changed from "돌아가도록" to "잘 되도록". Is that better?

## 새 Planet을 찾아서

현재 우리 플래닛은 쇠퇴하고 있습니다. 사용 중인 소프트웨어의 마지막 업데이트는 13년 전입니다.
기반 코드는 더 오래된 상태이지만 우리의 필요성은 앞으로 나아갔습니다.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's awkward because the verb is written in the past tense.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed from "나아갔습니다" to "나아가고 있습니다".

현재 사이트는 자주 고장이 나며 정기적인 개발자의 개입이 필요합니다.
앞으로는 우리가 집이라고 부를 새로운 Planet이 필요합니다.

2020년을 맞이하며 새로운 시스템으로 전환을 고려할 시기가 된 것으로 결정했습니다.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it will be a more natural and sophisticated context if it is expressed in Present perfect tense

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure how I can change this using present perfect tense in Korean.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to "2020년을 맞이하며 새로운 시스템으로 이전하는 것을 고려할 시기가 된 것으로 결정합니다." Is this better?

@vercel
Copy link

vercel bot commented Oct 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
telescope ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2023 8:40pm

@manekenpix
Copy link
Member

@HyoanMoon @avelynhc I'm making changes to our CI, that's why the checks are failing. You can still review this PR and approve it, I'll merge it when it's ready (don't worry about the checks, I'm still working on it).

@avelynhc
Copy link
Contributor Author

avelynhc commented Oct 3, 2023

@manekenpix Thanks for letting us know!

@manekenpix manekenpix merged commit 6cbb599 into Seneca-CDOT:master Oct 9, 2023
11 of 12 checks passed
@avelynhc avelynhc deleted the issue-3835 branch October 10, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation (docs) Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translate About page from English to Korean
3 participants