crc8: Use explicit error type #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnestler
force-pushed
the
use-explicit-error-type
branch
3 times, most recently
from
6efbb01
to
ef148f1
Compare
Even if just one error can happen, it may be beneficial to be able to have a separate error type to allow for `From<Error>` implementations.
rnestler
force-pushed
the
use-explicit-error-type
branch
from
ef148f1
to
241dd91
Compare
psachs
approved these changes
Jan 14, 2021
abrauchli
approved these changes
Jan 14, 2021
|
Thanks @barafael for the suggestion for this change! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if just one error can happen, it may be beneficial to be able to
have a separate error type to allow for
From<Error>implementations.