Self-healing Mosquitto (Dockerfile build) - PR 2 of 2 - old-menu branch #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements discussion contained in [Issue 331](SensorsIot#331): 1. Removes `directoryfix.sh`. No longer appropriate. 2. Adds Dockerfile to template folder. 3. Adds docker-entrypoint.sh to template folder (customised version of original). 4. Adds iotstack_defaults folder structure to template folder. 5. Moves filter.acl and mosquitto.conf into iotstack_defaults/config/ 6. Alters service.yml: * Builds from Dockerfile. * Adds environment key and TZ default. * Moves /mosquitto/config mapping from services to volumes and omits ":ro" flag Does not alter documentation on old-menu branch. Does not remove terminal.sh (mentioned in original old-menu documentation). Both approaches to password creation "work". I decided to leave terminal.sh to minimise the risk of confusion if someone was following the old-menu documentation and was unable to find terminal.sh.
Slyke
approved these changes
May 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self-healing Mosquitto (Dockerfile build) - PR 2 of 2 - old-menu branch
Implements discussion contained in Issue 331:
Removes
directoryfix.sh. No longer appropriate.Adds Dockerfile to template folder.
Adds docker-entrypoint.sh to template folder (customised version of original).
Adds iotstack_defaults folder structure to template folder.
Moves filter.acl and mosquitto.conf into iotstack_defaults/config/
Alters service.yml:
Does not alter documentation on old-menu branch.
Does not remove terminal.sh (mentioned in original old-menu documentation). Both approaches to password creation "work". I decided to leave terminal.sh to minimise the risk of confusion if someone was following the old-menu documentation and was unable to find terminal.sh.