Remove order: 'pre' from resolveId #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This causes the plugin to run too early in Vite, preventing any `resolve.alias` from taking effect or for any other plugin to handle node builtins, whether `builtins` or `builtinsPrefix` is set. For example, when you want to polyfill via alias some Node builtins, when building for both browser and Node.js. `enforce: 'pre'` is still needed to run early enough in the Vite plugins order. Which makes `resolveId` already run in the right place in the plugin order. For plain rollup, just place the plugin before other plugins that depend on aliases, for reference, the standard alias plugin doesn't include `order: 'pre'` as well, to allow control such control.
|
Hi, Sorry for the delay. TBH, I've always been wondering if having both I've made some testing and I think you are right, However, this is potentially a breaking change as it may force some users to reorganize the plugins order in their config, so for now I'll keep this in mind until the next major (which should come out very shortly). Thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes the plugin to run too early in Vite, preventing any
resolve.aliasfrom taking effect or for any other plugin to handle node builtins, whetherbuiltinsorbuiltinsPrefixis set.For example, when you want to polyfill via alias some Node builtins, when building for both browser and Node.js.
enforce: 'pre'is still needed to run early enough in the Vite plugins order. Which makesresolveIdalready run in the right place in the plugin order.For plain rollup, just place the plugin before other plugins that depend on aliases, for reference, the standard alias plugin doesn't include
order: 'pre'as well, to allow control such control.