Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Dataset/convert_longitude/fix unsuported in wrap new versions #59

Merged

Conversation

MAfarrag
Copy link
Member

@MAfarrag MAfarrag commented Nov 27, 2023

Description

  • The convert_longitude function used gdal_wrap to convert the 0 to 360 longitude to -180 to 180 , however gdal versions after 3.7.1, could not convert it anymore.

in pyramids before 0.5.0 the function used to calculate the conversion and in this merge i rolled back to using the calculation instead of the gdal_wrap function

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Please describe the tests that you ran to verify your changes.

  • Provide instructions so we can reproduce.

  • Please also list any relevant details for your test configuration

  • Test A

  • Test B

Checklist:

  • updated version number in setup.py/pyproject.toml.
  • updated environment.yml and the lock file.
  • added changes to History.rst.
  • updated the latest version in README file.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • documentation are updated.

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e718db5) 83.13% compared to head (9f414b4) 83.23%.

Files Patch % Lines
pyramids/dataset.py 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
+ Coverage   83.13%   83.23%   +0.09%     
==========================================
  Files           7        7              
  Lines        2081     2099      +18     
==========================================
+ Hits         1730     1747      +17     
- Misses        351      352       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MAfarrag MAfarrag merged commit 6e765b5 into main Nov 27, 2023
@MAfarrag MAfarrag deleted the dataset/convert_longitude/fix-unsuported-in-wrap-new-versions branch November 27, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant