Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dataset/dataset/domain-cells-for-different-bands #76

Merged
merged 6 commits into from
Jan 4, 2024

Conversation

MAfarrag
Copy link
Member

@MAfarrag MAfarrag commented Jan 4, 2024

count domain cells

Adjust the method count_domain_cells to take a parameter (band) to choose which band to count its cells in case of a multi band dataset

Check relevant points.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

two tests have been added to get the number of cells for two datasets (single and multi-band) and compare it with the correct number.

  • tests\dataset\test_dataset.py::TestCountDomainCells::test_single_band
  • tests\dataset\test_dataset.py::TestCountDomainCells::test_multi_band

Checklist:

  • updated version number in setup.py/pyproject.toml.
  • updated environment.yml and the lock file.
  • added changes to History.rst.
  • updated the latest version in README file.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • documentation are updated.

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (772bdc4) 84.50% compared to head (2c6ff49) 84.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #76   +/-   ##
=======================================
  Coverage   84.50%   84.50%           
=======================================
  Files           7        7           
  Lines        2143     2143           
=======================================
  Hits         1811     1811           
  Misses        332      332           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MAfarrag MAfarrag linked an issue Jan 4, 2024 that may be closed by this pull request
@MAfarrag MAfarrag added documentation Improvements or additions to documentation enhancement New feature or request dataset labels Jan 4, 2024
@MAfarrag MAfarrag merged commit da9cac3 into main Jan 4, 2024
10 checks passed
@MAfarrag MAfarrag deleted the dataset/dataset/domain-cells-for-different-bands branch January 4, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dataset documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

calculate the domain cells for a given band
1 participant