Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: replace deprecated request with got library #127

Merged
merged 1 commit into from
Sep 7, 2020
Merged

feat: replace deprecated request with got library #127

merged 1 commit into from
Sep 7, 2020

Conversation

DRoet
Copy link
Contributor

@DRoet DRoet commented Sep 7, 2020

Just minor maintenance by removing the deprecated request package and using got instead.

Tests should still pass

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling dc7d36f on DRoet:master into 54c6ddc on SerayaEryn:master.

SerayaEryn
SerayaEryn approved these changes Sep 7, 2020
View reviewed changes
Copy link
Owner

@SerayaEryn SerayaEryn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for your contribution.

@SerayaEryn SerayaEryn merged commit 16cae77 into SerayaEryn:master Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SerayaEryn SerayaEryn SerayaEryn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DRoet @coveralls @SerayaEryn