Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add equivalent PowerShell scripts #579

Merged
merged 3 commits into from
Jan 6, 2022
Merged

Add equivalent PowerShell scripts #579

merged 3 commits into from
Jan 6, 2022

Conversation

thayol
Copy link
Contributor

@thayol thayol commented Jan 5, 2022

Resolves #414

The PowerShell scripts should be equivalent of the Bash scripts. Could not test every situation, a large log file with every possibility would be welcome!

Also added a .gitattributes file to keep the CRLF line endings for Windows execution.

@Serene-Arc
Copy link
Owner

The easiest way to get the log files for every test are to use the ones in the bash tests, since they're the same format. The strings are in the code if you really want to use them too, you can substitute real-world values in pretty easily.

@thayol
Copy link
Contributor Author

thayol commented Jan 5, 2022

I've processed the test log files with PowerShell and it seems that even the Bash scripts produce the wrong result for failed_write_error.txt

Expected result: nnboza
Actual result: submissio

Currently, the Bash and PowerShell scripts behave identically. Should I create a new issue with the "write error" bug or should I include the solution in this PR?

@Serene-Arc
Copy link
Owner

Ah well if the bash scripts cause an error currently, open a new bug report for that. You or I can write a PR, but keep the powershell script separate. You can always rebase if needed

@thayol
Copy link
Contributor Author

thayol commented Jan 6, 2022

So the question is whether I should keep things like this and make the PowerShell scripts mirror what the Bash scripts do or should I commit (in this PR) the PS script that produces the "correct" result?

Asking because I can't make my next pull request that would "fix" the PS scripts too if the PS scripts don't exist.

@Serene-Arc
Copy link
Owner

Make the PS scripts do the right thing, don't knowingly commit a broken script. I'll check and merge the other PR

@thayol
Copy link
Contributor Author

thayol commented Jan 6, 2022

Now it is aligned with the test data, everything works as intended.

@Serene-Arc Serene-Arc merged commit 57b3bb3 into Serene-Arc:master Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] Add equivalent powershell scripts
2 participants